PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Recycle TypedArray in ConversationMessageView.

Browse Source 
Test: make RunSettingsRoboTests -j40
Change-Id: Iaf3f214588f23c232a23ecdadb7fe6222792fada
This commit is contained in:
Rajeev Kumar
2017-07-13 19:14:57 -07:00
parent 82ee7cf14f
commit 7d99df0228
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/display/ConversationMessageView.java
View File

@@ -29,7 +29,6 @@ import android.view.ViewGroup;
import android.widget.FrameLayout; import android.widget.FrameLayout;
import android.widget.LinearLayout; import android.widget.LinearLayout;
import android.widget.TextView; import android.widget.TextView;
import com.android.settings.R; import com.android.settings.R;
/** /**
@@ -76,7 +75,7 @@ public class ConversationMessageView extends FrameLayout {
mIconTextColor = a.getColor(R.styleable.ConversationMessageView_iconTextColor, 0); mIconTextColor = a.getColor(R.styleable.ConversationMessageView_iconTextColor, 0);
mIconBackgroundColor = a.getColor(R.styleable.ConversationMessageView_iconBackgroundColor, mIconBackgroundColor = a.getColor(R.styleable.ConversationMessageView_iconBackgroundColor,
0); 0);
a.recycle();
LayoutInflater.from(context).inflate(R.layout.conversation_message_icon, this); LayoutInflater.from(context).inflate(R.layout.conversation_message_icon, this);
LayoutInflater.from(context).inflate(R.layout.conversation_message_content, this); LayoutInflater.from(context).inflate(R.layout.conversation_message_content, this);
} }
@@ -252,7 +251,7 @@ public class ConversationMessageView extends FrameLayout {
private static Drawable getTintedDrawable(final Context context, final Drawable drawable, private static Drawable getTintedDrawable(final Context context, final Drawable drawable,
final int color) { final int color) {
// For some reason occassionally drawables on JB has a null constant state // For some reason occasionally drawables on JB has a null constant state
final Drawable.ConstantState constantStateDrawable = drawable.getConstantState(); final Drawable.ConstantState constantStateDrawable = drawable.getConstantState();
final Drawable retDrawable = (constantStateDrawable != null) final Drawable retDrawable = (constantStateDrawable != null)
? constantStateDrawable.newDrawable(context.getResources()).mutate() ? constantStateDrawable.newDrawable(context.getResources()).mutate()