From 9090f85a1252a21cc80ab9ba3c1dd984a596d7e0 Mon Sep 17 00:00:00 2001 From: Ajay Panicker Date: Mon, 17 Apr 2017 20:46:29 -0700 Subject: [PATCH] Limit btsnoop file size (4/8) Limit btsnoop file size by rotating between snoop files. The rotation occurrs when a fixed number of packets have been logged and will start overwriting the older file. Bug: 35998031 Test: Enable snoop logs from developer options and let logs get large Merged-In: I94f8f6bc12ab3f7ff406c9392934ecb7209cd635 Change-Id: I94f8f6bc12ab3f7ff406c9392934ecb7209cd635 --- src/com/android/settings/DevelopmentSettings.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/com/android/settings/DevelopmentSettings.java b/src/com/android/settings/DevelopmentSettings.java index c3d26894a0d..796b53f1d0a 100644 --- a/src/com/android/settings/DevelopmentSettings.java +++ b/src/com/android/settings/DevelopmentSettings.java @@ -204,6 +204,8 @@ public class DevelopmentSettings extends RestrictedSettingsFragment "persist.bluetooth.avrcpversion"; private static final String BLUETOOTH_ENABLE_INBAND_RINGING_PROPERTY = "persist.bluetooth.enableinbandringing"; + private static final String BLUETOOTH_BTSNOOP_ENABLE_PROPERTY = + "persist.bluetooth.btsnoopenable"; private static final String BLUETOOTH_ENABLE_INBAND_RINGING_KEY = "bluetooth_enable_inband_ringing"; private static final String BLUETOOTH_SELECT_AVRCP_VERSION_KEY = "bluetooth_select_avrcp_version"; @@ -738,8 +740,8 @@ public class DevelopmentSettings extends RestrictedSettingsFragment Settings.Global.BUGREPORT_IN_POWER_MENU, 0) != 0); updateSwitchPreference(mKeepScreenOn, Settings.Global.getInt(cr, Settings.Global.STAY_ON_WHILE_PLUGGED_IN, 0) != 0); - updateSwitchPreference(mBtHciSnoopLog, Settings.Secure.getInt(cr, - Settings.Secure.BLUETOOTH_HCI_LOG, 0) != 0); + updateSwitchPreference(mBtHciSnoopLog, SystemProperties.getBoolean( + BLUETOOTH_BTSNOOP_ENABLE_PROPERTY, false)); updateSwitchPreference(mDebugViewAttributes, Settings.Global.getInt(cr, Settings.Global.DEBUG_VIEW_ATTRIBUTES, 0) != 0); updateSwitchPreference(mForceAllowOnExternal, Settings.Global.getInt(cr, @@ -902,10 +904,8 @@ public class DevelopmentSettings extends RestrictedSettingsFragment private void writeBtHciSnoopLogOptions() { BluetoothAdapter adapter = BluetoothAdapter.getDefaultAdapter(); - adapter.configHciSnoopLog(mBtHciSnoopLog.isChecked()); - Settings.Secure.putInt(getActivity().getContentResolver(), - Settings.Secure.BLUETOOTH_HCI_LOG, - mBtHciSnoopLog.isChecked() ? 1 : 0); + SystemProperties.set(BLUETOOTH_BTSNOOP_ENABLE_PROPERTY, + Boolean.toString(mBtHciSnoopLog.isChecked())); } private boolean writeWebViewProviderOptions(Object newValue) {