Restrict secondary users to share Wi-Fi network am: 4c4a1f58c1
am: a30d123e12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17397180 Change-Id: If2619c93286363f268bb7021af1037195fcba4be Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
@@ -36,9 +36,11 @@ import android.net.wifi.WifiManager;
|
||||
import android.os.Bundle;
|
||||
import android.os.Handler;
|
||||
import android.os.PowerManager;
|
||||
import android.os.UserManager;
|
||||
import android.provider.Settings;
|
||||
import android.telephony.TelephonyManager;
|
||||
import android.text.TextUtils;
|
||||
import android.util.EventLog;
|
||||
import android.util.FeatureFlagUtils;
|
||||
import android.util.Log;
|
||||
import android.view.ContextMenu;
|
||||
@@ -206,6 +208,8 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
|
||||
* by the Test DPC tool in AFW mode.
|
||||
*/
|
||||
protected boolean mIsRestricted;
|
||||
@VisibleForTesting
|
||||
boolean mIsAdmin = true;
|
||||
|
||||
@VisibleForTesting
|
||||
AirplaneModeEnabler mAirplaneModeEnabler;
|
||||
@@ -287,6 +291,13 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
|
||||
addPreferences();
|
||||
|
||||
mIsRestricted = isUiRestricted();
|
||||
mIsAdmin = isAdminUser();
|
||||
}
|
||||
|
||||
private boolean isAdminUser() {
|
||||
final UserManager userManager = getSystemService(UserManager.class);
|
||||
if (userManager == null) return true;
|
||||
return userManager.isAdminUser();
|
||||
}
|
||||
|
||||
private void addPreferences() {
|
||||
@@ -552,7 +563,9 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
|
||||
}
|
||||
|
||||
if (mSelectedWifiEntry.canDisconnect()) {
|
||||
menu.add(Menu.NONE, MENU_ID_SHARE, 0 /* order */, R.string.share);
|
||||
if (mSelectedWifiEntry.canShare()) {
|
||||
addShareMenuIfSuitable(menu);
|
||||
}
|
||||
menu.add(Menu.NONE, MENU_ID_DISCONNECT, 1 /* order */,
|
||||
R.string.wifi_disconnect_button_text);
|
||||
}
|
||||
@@ -560,7 +573,7 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
|
||||
// "forget" for normal saved network. And "disconnect" for ephemeral network because it
|
||||
// could only be disconnected and be put in blocklists so it won't be used again.
|
||||
if (canForgetNetwork()) {
|
||||
menu.add(Menu.NONE, MENU_ID_FORGET, 0 /* order */, R.string.forget);
|
||||
addForgetMenuIfSuitable(menu);
|
||||
}
|
||||
|
||||
WifiConfiguration config = mSelectedWifiEntry.getWifiConfiguration();
|
||||
@@ -575,6 +588,23 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
|
||||
}
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
void addShareMenuIfSuitable(ContextMenu menu) {
|
||||
if (mIsAdmin) {
|
||||
menu.add(Menu.NONE, MENU_ID_SHARE, 0 /* order */, R.string.share);
|
||||
return;
|
||||
}
|
||||
Log.w(TAG, "Don't add the Wi-Fi share menu because the user is not an admin.");
|
||||
EventLog.writeEvent(0x534e4554, "206986392", -1 /* UID */, "User is not an admin");
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
void addForgetMenuIfSuitable(ContextMenu menu) {
|
||||
if (mIsAdmin) {
|
||||
menu.add(Menu.NONE, MENU_ID_FORGET, 0 /* order */, R.string.forget);
|
||||
}
|
||||
}
|
||||
|
||||
private boolean canForgetNetwork() {
|
||||
return mSelectedWifiEntry.canForget() && !WifiUtils.isNetworkLockedDown(getActivity(),
|
||||
mSelectedWifiEntry.getWifiConfiguration());
|
||||
|
Reference in New Issue
Block a user