From b61b7396614af63d48e46996ca437efc4d6268bf Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Wed, 30 Jun 2021 12:59:28 -0400 Subject: [PATCH] Properly set all data fields So stale data doesn't stick around when the view is recycled Test: manual: - dismiss a notification - set a short timer (a custom view notif) - check history after timer expires (so there are 2 notifs in 'recently dismissed') - stop the timer and check history - there are now 3 notifs and no stale text in any of them Fixes: 192294011 Change-Id: I229a0388a703b9df0d92eec81066a9a2f67e183e --- .../notification/history/NotificationSbnViewHolder.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/com/android/settings/notification/history/NotificationSbnViewHolder.java b/src/com/android/settings/notification/history/NotificationSbnViewHolder.java index c98b036d7e2..166ee5d4ffc 100644 --- a/src/com/android/settings/notification/history/NotificationSbnViewHolder.java +++ b/src/com/android/settings/notification/history/NotificationSbnViewHolder.java @@ -65,9 +65,6 @@ public class NotificationSbnViewHolder extends RecyclerView.ViewHolder { } void setTitle(CharSequence title) { - if (title == null) { - return; - } mTitle.setText(title); }