From 69db774bda24d5c8ae310c06ffe3b41faf3579c2 Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Wed, 13 Mar 2019 13:21:34 -0700 Subject: [PATCH] Turn on remote volume slider Since now media API support multiple clients. Fixes: 126199571 Test: Manual Change-Id: I8d01ca3a0d46eb8a4450002ddf9911a7fda7dd5b --- .../RemoteVolumePreferenceController.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/com/android/settings/notification/RemoteVolumePreferenceController.java b/src/com/android/settings/notification/RemoteVolumePreferenceController.java index 0ad307e4c40..37a493e3954 100644 --- a/src/com/android/settings/notification/RemoteVolumePreferenceController.java +++ b/src/com/android/settings/notification/RemoteVolumePreferenceController.java @@ -35,6 +35,7 @@ import com.android.settingslib.volume.MediaSessions; import java.io.IOException; import java.util.List; +import java.util.Objects; public class RemoteVolumePreferenceController extends VolumeSeekBarPreferenceController { @@ -58,14 +59,14 @@ public class RemoteVolumePreferenceController extends if (mActiveToken == null) { updateToken(token); } - if (mActiveToken == token) { + if (Objects.equals(mActiveToken, token)) { updatePreference(mPreference, mActiveToken, pi); } } @Override public void onRemoteRemoved(MediaSession.Token t) { - if (mActiveToken == t) { + if (Objects.equals(mActiveToken, t)) { updateToken(null); if (mPreference != null) { mPreference.setVisible(false); @@ -75,7 +76,7 @@ public class RemoteVolumePreferenceController extends @Override public void onRemoteVolumeChanged(MediaSession.Token token, int flags) { - if (mActiveToken == token) { + if (Objects.equals(mActiveToken, token)) { final MediaController.PlaybackInfo pi = mMediaController.getPlaybackInfo(); if (pi != null) { setSliderPosition(pi.getCurrentVolume()); @@ -116,13 +117,13 @@ public class RemoteVolumePreferenceController extends @OnLifecycleEvent(Lifecycle.Event.ON_RESUME) public void onResume() { super.onResume(); - //TODO(b/126199571): register callback once b/126890783 is fixed + mMediaSessions.init(); } @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE) public void onPause() { super.onPause(); - //TODO(b/126199571): unregister callback once b/126890783 is fixed + mMediaSessions.destroy(); } @Override @@ -189,8 +190,7 @@ public class RemoteVolumePreferenceController extends @Override public Class getBackgroundWorkerClass() { - //TODO(b/126199571): return RemoteVolumeSliceWorker once b/126890783 is fixed - return null; + return RemoteVolumeSliceWorker.class; } private void updatePreference(VolumeSeekBarPreference seekBarPreference,