PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix R.string.search_menu

Browse Source 
It's belong to namespace com.android.settingslib.search instead of
com.android.settingslib.widget

Fix: 295106566
Test: manual - on Developer Option page
Change-Id: I6f66509ebc89094f96e08860c2d034b3b22c3b50
This commit is contained in:
Chaohui Wang
2023-08-09 20:04:48 +08:00
parent 33d480ed56
commit 781ca69f9b
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/search/actionbar/SearchMenuController.java
View File

@@ -86,7 +86,7 @@ public class SearchMenuController implements LifecycleObserver, OnCreateOptionsM
return; return;
} }
final MenuItem searchItem = menu.add(Menu.NONE, MENU_SEARCH, 0 /* order */, final MenuItem searchItem = menu.add(Menu.NONE, MENU_SEARCH, 0 /* order */,
com.android.settingslib.widget.R.string.search_menu); R.string.search_menu);
searchItem.setIcon(com.android.settingslib.widget.R.drawable.ic_search_24dp); searchItem.setIcon(com.android.settingslib.widget.R.drawable.ic_search_24dp);
searchItem.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS); searchItem.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS);

5
tests/robotests/src/com/android/settings/search/actionbar/SearchMenuControllerTest.java
View File

@@ -33,6 +33,7 @@ import android.view.MenuItem;
import androidx.fragment.app.FragmentActivity; import androidx.fragment.app.FragmentActivity;
import com.android.settings.R;
import com.android.settings.core.InstrumentedFragment; import com.android.settings.core.InstrumentedFragment;
import com.android.settings.testutils.shadow.ShadowUtils; import com.android.settings.testutils.shadow.ShadowUtils;
@@ -71,7 +72,7 @@ public class SearchMenuControllerTest {
when(mHost.getActivity()).thenReturn(mActivity); when(mHost.getActivity()).thenReturn(mActivity);
when(mMenu.add(Menu.NONE, MENU_SEARCH, 0 /* order */, when(mMenu.add(Menu.NONE, MENU_SEARCH, 0 /* order */,
com.android.settingslib.widget.R.string.search_menu)) R.string.search_menu))
.thenReturn(mock(MenuItem.class)); .thenReturn(mock(MenuItem.class));
} }
@@ -81,7 +82,7 @@ public class SearchMenuControllerTest {
mHost.getSettingsLifecycle().onCreateOptionsMenu(mMenu, null /* inflater */); mHost.getSettingsLifecycle().onCreateOptionsMenu(mMenu, null /* inflater */);
verify(mMenu).add(Menu.NONE, MENU_SEARCH, 0 /* order */, verify(mMenu).add(Menu.NONE, MENU_SEARCH, 0 /* order */,
com.android.settingslib.widget.R.string.search_menu); R.string.search_menu);
} }
@Test @Test