PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refine carrier Wi-Fi functions

Browse Source 
- Sync the same design to query and set carrier Wi-Fi enabled status from MergedCarrierEntry

- Add more logs for issue tracking

Bug: 227236604
Test: manual test
atest -c CarrierWifiTogglePreferenceControllerTest \
         WifiPickerTrackerHelperTest

Change-Id: I869fa97bd24ed31a3224b4a395ffc97a17aa1471
This commit is contained in:
Weng Su
2022-05-24 03:13:03 +08:00
parent 97a3f54878
commit 77f9cbe315
4 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/network/CarrierWifiTogglePreferenceController.java
View File

@@ -23,7 +23,6 @@ import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
import com.android.settings.wifi.WifiPickerTrackerHelper; import com.android.settings.wifi.WifiPickerTrackerHelper;
import com.android.wifitrackerlib.WifiPickerTracker; import com.android.wifitrackerlib.WifiPickerTracker;
@@ -65,7 +64,7 @@ public class CarrierWifiTogglePreferenceController extends TogglePreferenceContr
@Override @Override
public boolean isChecked() { public boolean isChecked() {
return mWifiPickerTrackerHelper.isCarrierNetworkEnabled(mSubId); return mWifiPickerTrackerHelper.isCarrierNetworkEnabled();
} }
@Override @Override

13
src/com/android/settings/wifi/WifiPickerTrackerHelper.java
View File

@@ -117,16 +117,25 @@ public class WifiPickerTrackerHelper implements LifecycleObserver {
} }
/** Return the enabled/disabled state of the carrier network */ /** Return the enabled/disabled state of the carrier network */
public boolean isCarrierNetworkEnabled(int subId) { public boolean isCarrierNetworkEnabled() {
return mWifiManager.isCarrierNetworkOffloadEnabled(subId, true /* merged */); final MergedCarrierEntry mergedCarrierEntry = mWifiPickerTracker.getMergedCarrierEntry();
if (mergedCarrierEntry == null) {
Log.e(TAG, "Failed to get MergedCarrierEntry to query enabled status");
return false;
}
final boolean isCarrierNetworkEnabled = mergedCarrierEntry.isEnabled();
Log.i(TAG, "isCarrierNetworkEnabled:" + isCarrierNetworkEnabled);
return isCarrierNetworkEnabled;
} }
/** Enables/disables the carrier network */ /** Enables/disables the carrier network */
public void setCarrierNetworkEnabled(boolean enabled) { public void setCarrierNetworkEnabled(boolean enabled) {
final MergedCarrierEntry mergedCarrierEntry = mWifiPickerTracker.getMergedCarrierEntry(); final MergedCarrierEntry mergedCarrierEntry = mWifiPickerTracker.getMergedCarrierEntry();
if (mergedCarrierEntry == null) { if (mergedCarrierEntry == null) {
Log.e(TAG, "Unable to get MergedCarrierEntry to set enabled status");
return; return;
} }
Log.i(TAG, "setCarrierNetworkEnabled:" + enabled);
mergedCarrierEntry.setEnabled(enabled); mergedCarrierEntry.setEnabled(enabled);
} }

4
tests/unit/src/com/android/settings/network/CarrierWifiTogglePreferenceControllerTest.java
View File

@@ -107,14 +107,14 @@ public class CarrierWifiTogglePreferenceControllerTest {
@Test @Test
public void isChecked_carrierNetworkEnabled_returnTrue() { public void isChecked_carrierNetworkEnabled_returnTrue() {
doReturn(true).when(mWifiPickerTrackerHelper).isCarrierNetworkEnabled(SUB_ID); doReturn(true).when(mWifiPickerTrackerHelper).isCarrierNetworkEnabled();
assertThat(mController.isChecked()).isEqualTo(true); assertThat(mController.isChecked()).isEqualTo(true);
} }
@Test @Test
public void isChecked_carrierNetworkDisabled_returnFalse() { public void isChecked_carrierNetworkDisabled_returnFalse() {
doReturn(false).when(mWifiPickerTrackerHelper).isCarrierNetworkEnabled(SUB_ID); doReturn(false).when(mWifiPickerTrackerHelper).isCarrierNetworkEnabled();
assertThat(mController.isChecked()).isEqualTo(false); assertThat(mController.isChecked()).isEqualTo(false);
} }

10
tests/unit/src/com/android/settings/wifi/WifiPickerTrackerHelperTest.java
View File

@@ -24,7 +24,6 @@ import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong; import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never; import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
@@ -135,14 +134,13 @@ public class WifiPickerTrackerHelperTest {
@Test @Test
public void isCarrierNetworkEnabled_returnCorrect() { public void isCarrierNetworkEnabled_returnCorrect() {
doReturn(true).when(mWifiManager).isCarrierNetworkOffloadEnabled(SUB_ID, true /* merged */); when(mMergedCarrierEntry.isEnabled()).thenReturn(true);
assertThat(mWifiPickerTrackerHelper.isCarrierNetworkEnabled(SUB_ID)).isTrue(); assertThat(mWifiPickerTrackerHelper.isCarrierNetworkEnabled()).isTrue();
doReturn(false).when(mWifiManager) when(mMergedCarrierEntry.isEnabled()).thenReturn(false);
.isCarrierNetworkOffloadEnabled(SUB_ID, true /* merged */);
assertThat(mWifiPickerTrackerHelper.isCarrierNetworkEnabled(SUB_ID)).isFalse(); assertThat(mWifiPickerTrackerHelper.isCarrierNetworkEnabled()).isFalse();
} }
@Test @Test