From de4e056449dd72bfdc667bbeeb6785bbdc9b9206 Mon Sep 17 00:00:00 2001
From: Jesse Evans <jsje@google.com>
Date: Tue, 11 Apr 2017 17:17:44 -0700
Subject: [PATCH] Instant apps should not say App Installed by

Changes the text on the app installer details to say
"More info on {App Store Name}".

Test: make RunSettingsRoboTests
Bug: 36512295
Change-Id: I8629f840e9f4e5ce12ba91e9cb9def0db0471162
---
 res/values/strings.xml                                      | 3 +++
 .../android/settings/applications/InstalledAppDetails.java  | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/res/values/strings.xml b/res/values/strings.xml
index 57abe34ede4..9e4e533bcc2 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -3740,6 +3740,9 @@
     <!-- Manage applications, individual application info screen, summary for the option which will trigger application info in it's installer [CHAR_LIMIT=50] -->
     <string name="app_install_details_summary">App installed from <xliff:g id="app_store">%1$s</xliff:g></string>
 
+    <!-- Manage applications, individual application info screen, summary for the option which will trigger instant app info in it's installer [CHAR_LIMIT=50] -->
+    <string name="instant_app_details_summary">More info on <xliff:g id="app_store">%1$s</xliff:g></string>
+
     <!-- App Ops Settings --> <skip />
     <!-- [CHAR LIMIT=NONE] App ops settings title, on main settings screen. If clicked, the user is taken to a settings screen for app operations -->
     <string name="app_ops_settings">App ops</string>
diff --git a/src/com/android/settings/applications/InstalledAppDetails.java b/src/com/android/settings/applications/InstalledAppDetails.java
index 062356241ae..7814f64dec2 100755
--- a/src/com/android/settings/applications/InstalledAppDetails.java
+++ b/src/com/android/settings/applications/InstalledAppDetails.java
@@ -17,6 +17,7 @@
 package com.android.settings.applications;
 
 import android.Manifest.permission;
+import android.annotation.IdRes;
 import android.app.Activity;
 import android.app.ActivityManager;
 import android.app.AlertDialog;
@@ -1107,13 +1108,16 @@ public class InstalledAppDetails extends AppInfoBase
         if (installerLabel == null) {
             return;
         }
+        final int detailsStringId = AppUtils.isInstant(mPackageInfo.applicationInfo)
+                ? R.string.instant_app_details_summary
+                : R.string.app_install_details_summary;
         PreferenceCategory category = new PreferenceCategory(getPrefContext());
         category.setTitle(R.string.app_install_details_group_title);
         screen.addPreference(category);
         Preference pref = new Preference(getPrefContext());
         pref.setTitle(R.string.app_install_details_title);
         pref.setKey("app_info_store");
-        pref.setSummary(getString(R.string.app_install_details_summary, installerLabel));
+        pref.setSummary(getString(detailsStringId, installerLabel));
 
         Intent intent =
                 AppStoreUtil.getAppStoreLink(getContext(), installerPackageName, mPackageName);