From 63c4595b65faef4862e3d18700ffe57ecd7dc4f6 Mon Sep 17 00:00:00 2001 From: Mill Chen Date: Thu, 7 Jan 2021 20:10:32 +0800 Subject: [PATCH] Add the mutability flag to the pendingIntent Since Android S, it's required to specify a mutability flag when creating a PendingIntent. Fixes: 172812025 Fixes: 172811729 Test: robotests Change-Id: Ia77c189c99712eea524fb1bf68e39a087dcba95c --- .../slices/SliceFullCardRendererHelperTest.java | 4 +--- .../slices/SliceHalfCardRendererHelperTest.java | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceFullCardRendererHelperTest.java b/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceFullCardRendererHelperTest.java index 395748bc0fb..f5df4fafb94 100644 --- a/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceFullCardRendererHelperTest.java +++ b/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceFullCardRendererHelperTest.java @@ -48,8 +48,6 @@ import org.junit.runner.RunWith; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; -import java.util.Collections; - @RunWith(RobolectricTestRunner.class) public class SliceFullCardRendererHelperTest { @@ -138,7 +136,7 @@ public class SliceFullCardRendererHelperTest { mActivity, title.hashCode() /* requestCode */, new Intent("test action"), - 0 /* flags */); + PendingIntent.FLAG_IMMUTABLE); final SliceAction action = SliceAction.createDeeplink(pendingIntent, icon, ListBuilder.SMALL_IMAGE, title); return new ListBuilder(mActivity, TEST_SLICE_URI, ListBuilder.INFINITY) diff --git a/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceHalfCardRendererHelperTest.java b/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceHalfCardRendererHelperTest.java index 1286c2711ab..a7112d26cb6 100644 --- a/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceHalfCardRendererHelperTest.java +++ b/tests/robotests/src/com/android/settings/homepage/contextualcards/slices/SliceHalfCardRendererHelperTest.java @@ -106,7 +106,7 @@ public class SliceHalfCardRendererHelperTest { mActivity, title.hashCode() /* requestCode */, new Intent("test action"), - 0 /* flags */); + PendingIntent.FLAG_IMMUTABLE); final SliceAction action = SliceAction.createDeeplink(pendingIntent, icon, ListBuilder.SMALL_IMAGE, title); return new ListBuilder(mActivity, TEST_SLICE_URI, ListBuilder.INFINITY)