From 046ad86d790ba2c8321a4ff2a4bcff588e58610f Mon Sep 17 00:00:00 2001 From: Perry Wu Date: Thu, 10 Oct 2024 18:23:31 +0000 Subject: [PATCH] [Settings] Update PIP with new Settings integration Updates PIP settings to be compatible with new Settings guidelines. For context we have 2 settings pages PictureInPictureSettings.java and PictureInPictureDetails.java, both of which inherit from standard androidx components, so there should not be any other required changes. Bug: b/349659719 Flag: EXEMPT refactor Test: manually enable update and check settings pages Change-Id: Iafc3cda8cdb2fcdba466755bf537188ee2005dc2 --- .../pictureinpicture/PictureInPictureSettings.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureSettings.java b/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureSettings.java index f19b68a6cae..6fc74696a92 100644 --- a/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureSettings.java +++ b/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureSettings.java @@ -43,7 +43,6 @@ import com.android.settings.applications.AppInfoBase; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.widget.EmptyTextSettings; import com.android.settingslib.search.SearchIndexable; -import com.android.settingslib.widget.AppPreference; import java.text.Collator; import java.util.ArrayList; @@ -160,7 +159,7 @@ public class PictureInPictureSettings extends EmptyTextSettings { final String packageName = appInfo.packageName; final CharSequence label = appInfo.loadLabel(mPackageManager); - final Preference pref = new AppPreference(prefContext); + final Preference pref = new Preference(prefContext); pref.setIcon(mIconDrawableFactory.getBadgedIcon(appInfo, userId)); pref.setTitle(mPackageManager.getUserBadgedLabel(label, user)); pref.setSummary(PictureInPictureDetails.getPreferenceSummary(prefContext,