From 9ddd3445f0e4085bd60c562853bc271a3c2f06b3 Mon Sep 17 00:00:00 2001 From: Rafael Matias de Lima Date: Fri, 7 Feb 2020 11:35:48 -0300 Subject: [PATCH] Fix for User edit info dialog during rotation [issue] 1. Go to Settings > System > Multiple users; 2. Edit user info; 3. Take a picture in portrait mode; 4. Turn the device to landscape mode; Observe selected image is not retained; [rootcause] Fragments no longer need to check if the dialog is showing up during onSaveInstanceState. [test] 1. Edit user info; 2. Select a picture; 3. Turn the device to landscape mode; --- src/com/android/settings/users/EditUserInfoController.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/com/android/settings/users/EditUserInfoController.java b/src/com/android/settings/users/EditUserInfoController.java index 4d9244aeba5..a4ee477cd88 100644 --- a/src/com/android/settings/users/EditUserInfoController.java +++ b/src/com/android/settings/users/EditUserInfoController.java @@ -83,8 +83,7 @@ public class EditUserInfoController { } public void onSaveInstanceState(Bundle outState) { - if (mEditUserInfoDialog != null && mEditUserInfoDialog.isShowing() - && mEditUserPhotoController != null) { + if (mEditUserInfoDialog != null && mEditUserPhotoController != null) { // Bitmap cannot be stored into bundle because it may exceed parcel limit // Store it in a temporary file instead File file = mEditUserPhotoController.saveNewUserPhotoBitmap();