Merge "Avoid empty line for storage summary" into main

This commit is contained in:
Chaohui Wang
2024-01-19 03:06:14 +00:00
committed by Android (Google) Code Review
2 changed files with 42 additions and 4 deletions

View File

@@ -34,6 +34,7 @@ import com.android.settingslib.spa.framework.util.mapItem
import com.android.settingslib.spa.widget.preference.Preference
import com.android.settingslib.spa.widget.preference.PreferenceModel
import com.android.settingslib.spa.widget.ui.SpinnerOption
import com.android.settingslib.spaprivileged.framework.compose.getPlaceholder
import com.android.settingslib.spaprivileged.model.app.AppListModel
import com.android.settingslib.spaprivileged.model.app.AppRecord
import com.android.settingslib.spaprivileged.model.app.installed
@@ -131,7 +132,11 @@ class AllAppListModel(
override fun getSummary(option: Int, record: AppRecordWithSize): () -> String {
val storageSummary = record.app.getStorageSummary()
return {
val summaryList = mutableListOf(storageSummary.value)
val summaryList = mutableListOf<String>()
val storageSummaryValue = storageSummary.value
if (storageSummaryValue.isNotBlank()) {
summaryList += storageSummaryValue
}
when {
!record.app.installed && !record.app.isArchived -> {
summaryList += context.getString(R.string.not_installed)
@@ -142,6 +147,7 @@ class AllAppListModel(
}
}
summaryList.joinToString(separator = System.lineSeparator())
.ifEmpty { context.getPlaceholder() } // Use placeholder to reduce flaky
}
}