PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix GAR color constrast issue on dialog

Browse Source 
Based on the UX definition, we use color surface
for the background color of dialog.

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I2f89193f7c584e8fc468aa035ce329c22e2ad7f1
This commit is contained in:
Tsung-Mao Fang
2021-05-27 23:00:14 +08:00
parent a8e4d51c24
commit 732ff78505
4 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
res/values-night/colors.xml
View File

@@ -21,8 +21,6 @@
<color name="homepage_support_background">#3F5FBD</color> <color name="homepage_support_background">#3F5FBD</color>
<color name="homepage_card_dismissal_background">@*android:color/material_grey_900</color> <color name="homepage_card_dismissal_background">@*android:color/material_grey_900</color>
<color name="contextual_card_background">@*android:color/material_grey_900</color> <color name="contextual_card_background">@*android:color/material_grey_900</color>
<!-- Dialog background color. -->
<color name="dialog_background">@*android:color/material_grey_800</color>
<color name="notification_importance_selection_bg">@*android:color/material_grey_800</color> <color name="notification_importance_selection_bg">@*android:color/material_grey_800</color>
<color name="notification_importance_button_selected">#AECBFA</color> <!-- material blue 200 --> <color name="notification_importance_button_selected">#AECBFA</color> <!-- material blue 200 -->
<color name="notification_importance_button_unselected">#5F6368</color> <color name="notification_importance_button_unselected">#5F6368</color>

5
res/values-night/themes.xml
View File

@@ -15,7 +15,8 @@
limitations under the License. limitations under the License.
--> -->
<resources> <resources
xmlns:androidprv="http://schemas.android.com/apk/prv/res/android">
<style name="Theme.Settings.Home" parent="Theme.Settings.HomeBase"> <style name="Theme.Settings.Home" parent="Theme.Settings.HomeBase">
<item name="colorPrimary">@*android:color/primary_device_default_settings</item> <item name="colorPrimary">@*android:color/primary_device_default_settings</item>
@@ -31,7 +32,7 @@
<style name="Theme.AlertDialog.Base" parent="@style/Theme.AppCompat.DayNight.Dialog.Alert"> <style name="Theme.AlertDialog.Base" parent="@style/Theme.AppCompat.DayNight.Dialog.Alert">
<item name="colorAccent">@*android:color/accent_device_default_dark</item> <item name="colorAccent">@*android:color/accent_device_default_dark</item>
<item name="android:colorBackground">@color/dialog_background</item> <item name="android:colorBackground">?androidprv:attr/colorSurface</item>
</style> </style>
<!-- Material theme for the pages containing TabLayout and ViewPager --> <!-- Material theme for the pages containing TabLayout and ViewPager -->

3
res/values/colors.xml
View File

@@ -147,9 +147,6 @@
<!-- Search bar background color --> <!-- Search bar background color -->
<color name="search_bar_background">?androidprv:attr/colorSurface</color> <color name="search_bar_background">?androidprv:attr/colorSurface</color>
<!-- Dialog background color -->
<color name="dialog_background">@*android:color/background_device_default_light</color>
<color name="face_intro_outline">#ffdadce0</color> <color name="face_intro_outline">#ffdadce0</color>
<color name="back_gesture_indicator">#4182ef</color> <color name="back_gesture_indicator">#4182ef</color>

5
res/values/themes.xml
View File

@@ -14,7 +14,8 @@
limitations under the License. limitations under the License.
--> -->
<resources> <resources
xmlns:androidprv="http://schemas.android.com/apk/prv/res/android">
<style name="Transparent"> <style name="Transparent">
<item name="alertDialogTheme">@style/Theme.AlertDialog</item> <item name="alertDialogTheme">@style/Theme.AlertDialog</item>
@@ -129,7 +130,7 @@
<style name="Theme.AlertDialog.Base" parent="@style/Theme.AppCompat.DayNight.Dialog.Alert"> <style name="Theme.AlertDialog.Base" parent="@style/Theme.AppCompat.DayNight.Dialog.Alert">
<item name="colorAccent">@*android:color/accent_device_default_light</item> <item name="colorAccent">@*android:color/accent_device_default_light</item>
<item name="android:colorBackground">@color/dialog_background</item> <item name="android:colorBackground">?androidprv:attr/colorSurface</item>
</style> </style>
<style name="Theme.AlertDialog" parent="Theme.AlertDialog.Base"> <style name="Theme.AlertDialog" parent="Theme.AlertDialog.Base">