Merge "Fix for test failure in PrivateSpaceMaintainerTest" into main

This commit is contained in:
Joseph Vincent
2024-04-04 11:10:12 +00:00
committed by Android (Google) Code Review

View File

@@ -78,6 +78,8 @@ public class PrivateSpaceMaintainerTest {
/** Tests that {@link PrivateSpaceMaintainer#deletePrivateSpace()} deletes PS when PS exists. */ /** Tests that {@link PrivateSpaceMaintainer#deletePrivateSpace()} deletes PS when PS exists. */
@Test @Test
public void deletePrivateSpace_psExists_deletesPS() { public void deletePrivateSpace_psExists_deletesPS() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();
@@ -94,6 +96,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void deletePrivateSpace_psDoesNotExist_returnsNoPSError() { public void deletePrivateSpace_psDoesNotExist_returnsNoPSError() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
ErrorDeletingPrivateSpace errorDeletingPrivateSpace = ErrorDeletingPrivateSpace errorDeletingPrivateSpace =
@@ -106,6 +110,8 @@ public class PrivateSpaceMaintainerTest {
/** Tests that {@link PrivateSpaceMaintainer#createPrivateSpace()} when PS exists creates PS. */ /** Tests that {@link PrivateSpaceMaintainer#createPrivateSpace()} when PS exists creates PS. */
@Test @Test
public void createPrivateSpace_psDoesNotExist_createsPS() { public void createPrivateSpace_psDoesNotExist_createsPS() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.deletePrivateSpace(); privateSpaceMaintainer.deletePrivateSpace();
@@ -119,6 +125,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void createPrivateSpace_psExists_returnsFalse() { public void createPrivateSpace_psExists_returnsFalse() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.deletePrivateSpace(); privateSpaceMaintainer.deletePrivateSpace();
@@ -133,6 +141,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void createPrivateSpace_psDoesNotExist_resetsHidePSSettings() { public void createPrivateSpace_psDoesNotExist_resetsHidePSSettings() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
Settings.Secure.putInt( Settings.Secure.putInt(
@@ -171,6 +181,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void createPrivateSpace_psExists_doesNotResetHidePSSettings() { public void createPrivateSpace_psExists_doesNotResetHidePSSettings() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();
@@ -190,6 +202,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void lockPrivateSpace_psExistsAndPrivateProfileRunning_locksCreatedPrivateSpace() { public void lockPrivateSpace_psExistsAndPrivateProfileRunning_locksCreatedPrivateSpace() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();
@@ -206,6 +220,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void lockPrivateSpace_psExistsAndPrivateProfileNotRunning_returnsFalse() { public void lockPrivateSpace_psExistsAndPrivateProfileNotRunning_returnsFalse() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();
@@ -226,6 +242,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void lockPrivateSpace_psDoesNotExist_returnsFalse() { public void lockPrivateSpace_psDoesNotExist_returnsFalse() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
assertThat(privateSpaceMaintainer.doesPrivateSpaceExist()).isFalse(); assertThat(privateSpaceMaintainer.doesPrivateSpaceExist()).isFalse();
@@ -238,6 +256,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void createPrivateSpace_psDoesNotExist_setsUserSetupComplete() { public void createPrivateSpace_psDoesNotExist_setsUserSetupComplete() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();
@@ -250,6 +270,8 @@ public class PrivateSpaceMaintainerTest {
*/ */
@Test @Test
public void createPrivateSpace_pSExists_doesNotChangeUserSetupSetting() { public void createPrivateSpace_pSExists_doesNotChangeUserSetupSetting() {
mSetFlagsRule.enableFlags(
android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES);
PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer privateSpaceMaintainer =
PrivateSpaceMaintainer.getInstance(mContext); PrivateSpaceMaintainer.getInstance(mContext);
privateSpaceMaintainer.createPrivateSpace(); privateSpaceMaintainer.createPrivateSpace();