From 28c0d90491d58af05535d39aa7ac6515954d2a94 Mon Sep 17 00:00:00 2001 From: Joshua McCloskey Date: Thu, 2 Jun 2022 22:55:53 +0000 Subject: [PATCH] Clear FP error only on progress. Test: Manually verified progress is cleared only when the user makes progress on fp enrollment. Fixes: 234094887 Change-Id: I173d2edb94132a4f68e0ef90aa9fa8008a25236f --- .../biometrics/fingerprint/FingerprintEnrollEnrolling.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java index 98210b3babb..df65a69c7c6 100644 --- a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java +++ b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java @@ -508,7 +508,6 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { public void onEnrollmentProgressChange(int steps, int remaining) { updateProgress(true /* animate */); updateTitleAndDescription(); - clearError(); animateFlash(); if (!mCanAssumeUdfps) { mErrorText.removeCallbacks(mTouchAgainRunnable); @@ -537,6 +536,11 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { int progress = getProgress( mSidecar.getEnrollmentSteps(), mSidecar.getEnrollmentRemaining()); + // Only clear the error when progress has been made. + // TODO (b/234772728) Add tests. + if (mProgressBar != null && mProgressBar.getProgress() < progress) { + clearError(); + } if (animate) { animateProgress(progress); } else {