From 350a930c68fa35d912e11d319848ac44bd868d59 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Wed, 1 Jun 2016 13:45:25 -0400 Subject: [PATCH] onResume -> onStart, onPause -> onStop For SettingsActivity and DashboardSummary Bug: 28896214 Change-Id: I235d5c82b04b1363bf4416acb5cf5fc1c4db704f --- .../android/settings/SettingsActivity.java | 21 +++++++------------ .../settings/dashboard/DashboardSummary.java | 10 ++++----- 2 files changed, 13 insertions(+), 18 deletions(-) diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index 9c8d410d1e2..d989535cf28 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -427,15 +427,6 @@ public class SettingsActivity extends SettingsDrawerActivity Index.getInstance(this).update(); } - @Override - protected void onStart() { - super.onStart(); - - if (mNeedToRevertToInitialFragment) { - revertToInitialFragment(); - } - } - @Override public boolean onCreateOptionsMenu(Menu menu) { if (!mDisplaySearch) { @@ -788,8 +779,12 @@ public class SettingsActivity extends SettingsDrawerActivity } @Override - protected void onResume() { - super.onResume(); + protected void onStart() { + super.onStart(); + + if (mNeedToRevertToInitialFragment) { + revertToInitialFragment(); + } mDevelopmentPreferencesListener = new SharedPreferences.OnSharedPreferenceChangeListener() { @Override @@ -813,8 +808,8 @@ public class SettingsActivity extends SettingsDrawerActivity } @Override - protected void onPause() { - super.onPause(); + protected void onStop() { + super.onStop(); unregisterReceiver(mBatteryInfoReceiver); unregisterReceiver(mUserAddRemoveReceiver); mDynamicIndexableContentMonitor.unregister(); diff --git a/src/com/android/settings/dashboard/DashboardSummary.java b/src/com/android/settings/dashboard/DashboardSummary.java index e08173f26df..a53f41bf2c2 100644 --- a/src/com/android/settings/dashboard/DashboardSummary.java +++ b/src/com/android/settings/dashboard/DashboardSummary.java @@ -110,9 +110,9 @@ public class DashboardSummary extends InstrumentedFragment } @Override - public void onResume() { + public void onStart() { long startTime = System.currentTimeMillis(); - super.onResume(); + super.onStart(); ((SettingsDrawerActivity) getActivity()).addCategoryListener(this); mSummaryLoader.setListening(true); @@ -127,13 +127,13 @@ public class DashboardSummary extends InstrumentedFragment DashboardAdapter.getSuggestionIdentifier(getContext(), suggestion)); } } - if (DEBUG_TIMING) Log.d(TAG, "onResume took " + (System.currentTimeMillis() - startTime) + if (DEBUG_TIMING) Log.d(TAG, "onStart took " + (System.currentTimeMillis() - startTime) + " ms"); } @Override - public void onPause() { - super.onPause(); + public void onStop() { + super.onStop(); ((SettingsDrawerActivity) getActivity()).remCategoryListener(this); mSummaryLoader.setListening(false);