From d729029b904d43c5c6d06f1d95004fe35445873d Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Tue, 1 Jul 2014 14:32:03 -0700 Subject: [PATCH] Fix some Dashboard top categories not showing for Search - fix Date & time / Printing / Security See bug: #12910134 Implement Search into the Settings App Change-Id: I7e96eb35a6802fde7589ccfe244e71f8be43dea8 --- res/values/strings.xml | 2 +- .../android/settings/SecuritySettings.java | 5 ++++- .../settings/print/PrintSettingsFragment.java | 20 +++++++++++-------- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index ea6ece6657a..781a691dffb 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -380,7 +380,7 @@ - Date & time settings + Date & time Choose time zone diff --git a/src/com/android/settings/SecuritySettings.java b/src/com/android/settings/SecuritySettings.java index 33ad1706a90..940b3e0bab2 100644 --- a/src/com/android/settings/SecuritySettings.java +++ b/src/com/android/settings/SecuritySettings.java @@ -699,7 +699,10 @@ public class SecuritySettings extends SettingsPreferenceFragment final String screenTitle = res.getString(R.string.security_settings_title); - SearchIndexableRaw data; + SearchIndexableRaw data = new SearchIndexableRaw(context); + data.title = screenTitle; + data.screenTitle = screenTitle; + result.add(data); if (!mIsPrimary) { int resId = (UserManager.get(context).isLinkedUser()) ? diff --git a/src/com/android/settings/print/PrintSettingsFragment.java b/src/com/android/settings/print/PrintSettingsFragment.java index f512db5b7fb..f883c7fcea5 100644 --- a/src/com/android/settings/print/PrintSettingsFragment.java +++ b/src/com/android/settings/print/PrintSettingsFragment.java @@ -528,8 +528,12 @@ public class PrintSettingsFragment extends SettingsPreferenceFragment Context.PRINT_SERVICE); String screenTitle = context.getResources().getString(R.string.print_settings); + SearchIndexableRaw data = new SearchIndexableRaw(context); + data.title = screenTitle; + data.screenTitle = screenTitle; + indexables.add(data); - // Indexing all services, reagardles if enabled. + // Indexing all services, regardless if enabled. List services = printManager.getInstalledPrintServices(); final int serviceCount = services.size(); for (int i = 0; i < serviceCount; i++) { @@ -539,13 +543,13 @@ public class PrintSettingsFragment extends SettingsPreferenceFragment service.getResolveInfo().serviceInfo.packageName, service.getResolveInfo().serviceInfo.name); - SearchIndexableRaw indexable = new SearchIndexableRaw(context); - indexable.key = componentName.flattenToString(); - indexable.title = service.getResolveInfo().loadLabel(packageManager).toString(); - indexable.summaryOn = context.getString(R.string.print_feature_state_on); - indexable.summaryOff = context.getString(R.string.print_feature_state_off); - indexable.screenTitle = screenTitle; - indexables.add(indexable); + data = new SearchIndexableRaw(context); + data.key = componentName.flattenToString(); + data.title = service.getResolveInfo().loadLabel(packageManager).toString(); + data.summaryOn = context.getString(R.string.print_feature_state_on); + data.summaryOff = context.getString(R.string.print_feature_state_off); + data.screenTitle = screenTitle; + indexables.add(data); } return indexables;