From dfd5e4fed5fa4db16b0e202758ad50bdaf9e01b9 Mon Sep 17 00:00:00 2001 From: Daniel Hunt Date: Wed, 9 Oct 2019 11:51:01 +0200 Subject: [PATCH] Skip loading contextual cards if legacy cards are used This stops a jarring animation that occurs when returning to the settings top level when legacy contextual cards are enabled and shown at the top of the top level list, Bug: 142936956 Test: Manual Change-Id: I43605adf6f1bf63cc40157ac97c8e3295dd3cd99 --- .../homepage/contextualcards/ContextualCardManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java b/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java index a941fdbfdf3..60a63ecb5dc 100644 --- a/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java +++ b/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java @@ -37,6 +37,7 @@ import androidx.annotation.VisibleForTesting; import androidx.loader.app.LoaderManager; import androidx.loader.content.Loader; +import com.android.settings.R; import com.android.settings.homepage.contextualcards.conditional.ConditionalCardController; import com.android.settings.homepage.contextualcards.logging.ContextualCardLogUtils; import com.android.settings.homepage.contextualcards.slices.SliceContextualCardRenderer; @@ -119,6 +120,10 @@ public class ContextualCardManager implements ContextualCardLoader.CardContentLo } void loadContextualCards(LoaderManager loaderManager) { + if (mContext.getResources().getBoolean(R.bool.config_use_legacy_suggestion)) { + Log.w(TAG, "Legacy suggestion contextual card enabled, skipping contextual cards."); + return; + } mStartTime = System.currentTimeMillis(); final CardContentLoaderCallbacks cardContentLoaderCallbacks = new CardContentLoaderCallbacks(mContext);