Merge "Use ColorDisplayManager for night display settings"

This commit is contained in:
Christine Franks
2019-02-07 16:11:14 +00:00
committed by Android (Google) Code Review
3 changed files with 24 additions and 21 deletions

View File

@@ -16,26 +16,25 @@ package com.android.settings.display;
import android.content.Context; import android.content.Context;
import android.hardware.display.ColorDisplayManager; import android.hardware.display.ColorDisplayManager;
import android.hardware.display.NightDisplayListener;
import android.util.AttributeSet; import android.util.AttributeSet;
import androidx.preference.SwitchPreference; import androidx.preference.SwitchPreference;
import com.android.internal.app.ColorDisplayController;
import java.time.LocalTime; import java.time.LocalTime;
public class NightDisplayPreference extends SwitchPreference public class NightDisplayPreference extends SwitchPreference
implements ColorDisplayController.Callback { implements NightDisplayListener.Callback {
private ColorDisplayManager mColorDisplayManager; private ColorDisplayManager mColorDisplayManager;
private ColorDisplayController mController; private NightDisplayListener mNightDisplayListener;
private NightDisplayTimeFormatter mTimeFormatter; private NightDisplayTimeFormatter mTimeFormatter;
public NightDisplayPreference(Context context, AttributeSet attrs) { public NightDisplayPreference(Context context, AttributeSet attrs) {
super(context, attrs); super(context, attrs);
mColorDisplayManager = context.getSystemService(ColorDisplayManager.class); mColorDisplayManager = context.getSystemService(ColorDisplayManager.class);
mController = new ColorDisplayController(context); mNightDisplayListener = new NightDisplayListener(context);
mTimeFormatter = new NightDisplayTimeFormatter(context); mTimeFormatter = new NightDisplayTimeFormatter(context);
} }
@@ -44,7 +43,7 @@ public class NightDisplayPreference extends SwitchPreference
super.onAttached(); super.onAttached();
// Listen for changes only while attached. // Listen for changes only while attached.
mController.setListener(this); mNightDisplayListener.setCallback(this);
// Update the summary since the state may have changed while not attached. // Update the summary since the state may have changed while not attached.
updateSummary(); updateSummary();
@@ -55,7 +54,7 @@ public class NightDisplayPreference extends SwitchPreference
super.onDetached(); super.onDetached();
// Stop listening for state changes. // Stop listening for state changes.
mController.setListener(null); mNightDisplayListener.setCallback(null);
} }
@Override @Override

View File

@@ -21,12 +21,12 @@ import android.app.TimePickerDialog;
import android.app.settings.SettingsEnums; import android.app.settings.SettingsEnums;
import android.content.Context; import android.content.Context;
import android.hardware.display.ColorDisplayManager; import android.hardware.display.ColorDisplayManager;
import android.hardware.display.NightDisplayListener;
import android.os.Bundle; import android.os.Bundle;
import android.provider.SearchIndexableResource; import android.provider.SearchIndexableResource;
import androidx.preference.Preference; import androidx.preference.Preference;
import com.android.internal.app.ColorDisplayController;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.dashboard.DashboardFragment; import com.android.settings.dashboard.DashboardFragment;
import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.BaseSearchIndexProvider;
@@ -43,7 +43,7 @@ import java.util.List;
*/ */
@SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC) @SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC)
public class NightDisplaySettings extends DashboardFragment public class NightDisplaySettings extends DashboardFragment
implements ColorDisplayController.Callback { implements NightDisplayListener.Callback {
private static final String TAG = "NightDisplaySettings"; private static final String TAG = "NightDisplaySettings";
@@ -51,7 +51,7 @@ public class NightDisplaySettings extends DashboardFragment
private static final int DIALOG_END_TIME = 1; private static final int DIALOG_END_TIME = 1;
private ColorDisplayManager mColorDisplayManager; private ColorDisplayManager mColorDisplayManager;
private ColorDisplayController mController; private NightDisplayListener mNightDisplayListener;
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
@@ -59,7 +59,7 @@ public class NightDisplaySettings extends DashboardFragment
final Context context = getContext(); final Context context = getContext();
mColorDisplayManager = context.getSystemService(ColorDisplayManager.class); mColorDisplayManager = context.getSystemService(ColorDisplayManager.class);
mController = new ColorDisplayController(context); mNightDisplayListener = new NightDisplayListener(context);
} }
@Override @Override
@@ -67,7 +67,7 @@ public class NightDisplaySettings extends DashboardFragment
super.onStart(); super.onStart();
// Listen for changes only while visible. // Listen for changes only while visible.
mController.setListener(this); mNightDisplayListener.setCallback(this);
} }
@Override @Override
@@ -75,7 +75,7 @@ public class NightDisplaySettings extends DashboardFragment
super.onStop(); super.onStop();
// Stop listening for state changes. // Stop listening for state changes.
mController.setListener(null); mNightDisplayListener.setCallback(null);
} }
@Override @Override

View File

@@ -19,7 +19,8 @@ package com.android.settings.homepage.contextualcards.conditional;
import android.app.settings.SettingsEnums; import android.app.settings.SettingsEnums;
import android.content.Context; import android.content.Context;
import com.android.internal.app.ColorDisplayController; import android.hardware.display.ColorDisplayManager;
import android.hardware.display.NightDisplayListener;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.SubSettingLauncher;
import com.android.settings.display.NightDisplaySettings; import com.android.settings.display.NightDisplaySettings;
@@ -28,17 +29,20 @@ import com.android.settings.homepage.contextualcards.ContextualCard;
import java.util.Objects; import java.util.Objects;
public class NightDisplayConditionController implements ConditionalCardController, public class NightDisplayConditionController implements ConditionalCardController,
ColorDisplayController.Callback { NightDisplayListener.Callback {
static final int ID = Objects.hash("NightDisplayConditionController"); static final int ID = Objects.hash("NightDisplayConditionController");
private final Context mAppContext; private final Context mAppContext;
private final ConditionManager mConditionManager; private final ConditionManager mConditionManager;
private final ColorDisplayController mController; private final ColorDisplayManager mColorDisplayManager;
private final NightDisplayListener mNightDisplayListener;
public NightDisplayConditionController(Context appContext, ConditionManager manager) { public NightDisplayConditionController(Context appContext, ConditionManager manager) {
mController = new ColorDisplayController(appContext);
mAppContext = appContext; mAppContext = appContext;
mConditionManager = manager; mConditionManager = manager;
mColorDisplayManager = appContext.getSystemService(ColorDisplayManager.class);
mNightDisplayListener = new NightDisplayListener(appContext);
} }
@Override @Override
@@ -48,7 +52,7 @@ public class NightDisplayConditionController implements ConditionalCardControlle
@Override @Override
public boolean isDisplayable() { public boolean isDisplayable() {
return mController.isActivated(); return mColorDisplayManager.isNightDisplayActivated();
} }
@Override @Override
@@ -62,7 +66,7 @@ public class NightDisplayConditionController implements ConditionalCardControlle
@Override @Override
public void onActionClick() { public void onActionClick() {
mController.setActivated(false); mColorDisplayManager.setNightDisplayActivated(false);
} }
@Override @Override
@@ -84,12 +88,12 @@ public class NightDisplayConditionController implements ConditionalCardControlle
@Override @Override
public void startMonitoringStateChange() { public void startMonitoringStateChange() {
mController.setListener(this); mNightDisplayListener.setCallback(this);
} }
@Override @Override
public void stopMonitoringStateChange() { public void stopMonitoringStateChange() {
mController.setListener(null); mNightDisplayListener.setCallback(null);
} }
@Override @Override