Merge "Updating colors for dark theme" into qt-r1-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
6d24819758
@@ -3037,4 +3037,36 @@
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" <color name="face_intro_outline">#ffdadce0</color> </color>"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values/colors.xml"
|
||||
line="150"
|
||||
column="40"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" android:fillColor="@color/face_intro_outline""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/drawable/face_enroll_introduction.xml"
|
||||
line="25"
|
||||
column="40"/>
|
||||
</issue>
|
||||
|
||||
</issues>
|
||||
|
@@ -22,7 +22,7 @@
|
||||
android:viewportHeight="300">
|
||||
|
||||
<path
|
||||
android:fillColor="#DADCE0"
|
||||
android:fillColor="@color/face_intro_outline"
|
||||
android:fillType="evenOdd"
|
||||
android:pathData="M150,0C67.16,0,0,67.16,0,150s67.16,150,150,150 s150-67.16,150-150S232.84,0,150,0 M150,4c39,0,75.66,15.19,103.24,42.76C280.81,74.34,296,111,296,150s-15.19,75.66-42.76,103.24 C225.66,280.81,189,296,150,296s-75.66-15.19-103.24-42.76C19.19,225.66,4,189,4,150S19.19,74.34,46.76,46.76 C74.34,19.19,111,4,150,4" />
|
||||
<path
|
||||
|
@@ -27,5 +27,6 @@
|
||||
<color name="notification_importance_selection_bg">@*android:color/material_grey_800</color>
|
||||
<color name="notification_importance_button_selected">#AECBFA</color> <!-- material blue 200 -->
|
||||
<color name="notification_importance_button_unselected">#5F6368</color>
|
||||
<color name="face_intro_outline">?android:attr/colorAccent</color>
|
||||
</resources>
|
||||
|
||||
|
@@ -147,4 +147,5 @@
|
||||
<!-- Dialog background color -->
|
||||
<color name="dialog_background">@*android:color/background_device_default_light</color>
|
||||
|
||||
<color name="face_intro_outline">#ffdadce0</color>
|
||||
</resources>
|
Reference in New Issue
Block a user