From 575fe1af95864819d457c08e169b1af5c269bcfb Mon Sep 17 00:00:00 2001 From: Nathan Harold Date: Fri, 12 Feb 2016 10:03:36 -0800 Subject: [PATCH] Update BandMode Names to support full list, fix off-by-one UI error. -Added support for all the currently defined band modes. -Fixed an off-by-one error in the UI that prevented single-band phones from being able to select a valid band. Bug: 27145805 Change-Id: If7366294086e28ebb51aa2f4b89c881c38deacc2 --- src/com/android/settings/BandMode.java | 34 ++++++++++++++++++++------ 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/src/com/android/settings/BandMode.java b/src/com/android/settings/BandMode.java index 81e8b4987de..c258773a9e6 100644 --- a/src/com/android/settings/BandMode.java +++ b/src/com/android/settings/BandMode.java @@ -37,13 +37,27 @@ public class BandMode extends Activity { private static final int EVENT_BAND_SCAN_COMPLETED = 100; private static final int EVENT_BAND_SELECTION_DONE = 200; + //Directly maps to RIL_RadioBandMode from ril.h private static final String[] BAND_NAMES = new String[] { "Automatic", - "EURO Band", - "USA Band", - "JAPAN Band", - "AUS Band", - "AUS2 Band" + "Europe", + "United States", + "Japan", + "Australia", + "Australia 2", + "Cellular 800", + "PCS", + "Class 3 (JTACS)", + "Class 4 (Korea-PCS)", + "Class 5", + "Class 6 (IMT2000)", + "Class 7 (700Mhz-Upper)", + "Class 8 (1800Mhz-Upper)", + "Class 9 (900Mhz)", + "Class 10 (800Mhz-Secondary)", + "Class 11 (Europe PAMR 400Mhz)", + "Class 15 (US-AWS)", + "Class 16 (US-2500Mhz)" }; private ListView mBandList; @@ -140,10 +154,16 @@ public class BandMode extends Activity { if (result.result != null) { int bands[] = (int[])result.result; + + if(bands.length == 0) { + Log.wtf(LOG_TAG, "No Supported Band Modes"); + return; + } + int size = bands[0]; if (size > 0) { - for (int i=1; i