From 69f46a72fc7867b9dc003b1089b0920f36aa56e4 Mon Sep 17 00:00:00 2001 From: ykhung Date: Tue, 1 Aug 2023 17:59:44 +0800 Subject: [PATCH] Update the incompatible charging banner tip icon Update the incompatible banner tip icon based on the UX update: https://screenshot.googleplex.com/8ApTNJnsxRRufjQ Fix: 246960554 Test: make test RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.fuelgauge Change-Id: I060554c17b3825b38004fb643c0a0cdf5fdbed4d --- res/drawable/ic_battery_charger.xml | 25 +++++++++++++++++++ .../BatterySettingsMigrateChecker.java | 5 ++-- .../tips/IncompatibleChargerTip.java | 2 +- .../tips/IncompatibleChargerTipTest.java | 2 +- 4 files changed, 29 insertions(+), 5 deletions(-) create mode 100644 res/drawable/ic_battery_charger.xml diff --git a/res/drawable/ic_battery_charger.xml b/res/drawable/ic_battery_charger.xml new file mode 100644 index 00000000000..4406a568a3d --- /dev/null +++ b/res/drawable/ic_battery_charger.xml @@ -0,0 +1,25 @@ + + + + + diff --git a/src/com/android/settings/fuelgauge/BatterySettingsMigrateChecker.java b/src/com/android/settings/fuelgauge/BatterySettingsMigrateChecker.java index 4b9e6efaff0..8697e438888 100644 --- a/src/com/android/settings/fuelgauge/BatterySettingsMigrateChecker.java +++ b/src/com/android/settings/fuelgauge/BatterySettingsMigrateChecker.java @@ -16,8 +16,8 @@ package com.android.settings.fuelgauge; -import android.content.ContentResolver; import android.content.BroadcastReceiver; +import android.content.ContentResolver; import android.content.Context; import android.content.Intent; import android.provider.Settings; @@ -25,8 +25,6 @@ import android.util.Log; import androidx.annotation.VisibleForTesting; -import com.android.settings.R; -import com.android.settings.fuelgauge.BatteryOptimizeHistoricalLogEntry; import com.android.settings.fuelgauge.batterysaver.BatterySaverScheduleRadioButtonsController; import com.android.settingslib.fuelgauge.BatterySaverUtils; @@ -41,6 +39,7 @@ public final class BatterySettingsMigrateChecker extends BroadcastReceiver { @Override public void onReceive(Context context, Intent intent) { + Log.d(TAG, "onReceive: " + intent + " owner: " + BatteryBackupHelper.isOwner()); if (intent != null && Intent.ACTION_BOOT_COMPLETED.equals(intent.getAction()) && BatteryBackupHelper.isOwner()) { diff --git a/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTip.java b/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTip.java index 1c5616f8675..48cfb7a4889 100644 --- a/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTip.java +++ b/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTip.java @@ -52,7 +52,7 @@ public final class IncompatibleChargerTip extends BatteryTip { @Override public int getIconId() { - return R.drawable.ic_battery_alert_theme; + return R.drawable.ic_battery_charger; } @Override diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTipTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTipTest.java index a5f1ab3f531..9f6e4e32a71 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTipTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/tips/IncompatibleChargerTipTest.java @@ -85,7 +85,7 @@ public final class IncompatibleChargerTipTest { @Test public void getIcon_showIcon() { assertThat(mIncompatibleChargerTip.getIconId()) - .isEqualTo(R.drawable.ic_battery_alert_theme); + .isEqualTo(R.drawable.ic_battery_charger); } @Test