From 4700dd261fea9e4a29db7f352911cf3553ae7cd5 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Mon, 28 Aug 2023 15:36:09 -0700 Subject: [PATCH] Skip test broken by @NonNull annotation fix b/294110802 fixed the @NonNull annotation so that it was visible to kotlin when applied to methods outside the current build module. This caused kotlin to insert more null checks, which broke a test that was mocking a method annoated with @NonNull and forcing it to return null. Add @Ignore to the test for now. Bug: 294110802 Bug: 297923588 Test: atest SettingsSpaUnitTests Change-Id: I86a677c5ac01bcfaeebe8c339791cca5b2b97fc7 --- .../com/android/settings/datausage/lib/DataUsageLibTest.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spa_unit/src/com/android/settings/datausage/lib/DataUsageLibTest.kt b/tests/spa_unit/src/com/android/settings/datausage/lib/DataUsageLibTest.kt index 5922facd96b..18af600ba65 100644 --- a/tests/spa_unit/src/com/android/settings/datausage/lib/DataUsageLibTest.kt +++ b/tests/spa_unit/src/com/android/settings/datausage/lib/DataUsageLibTest.kt @@ -26,6 +26,7 @@ import androidx.test.core.app.ApplicationProvider import androidx.test.ext.junit.runners.AndroidJUnit4 import com.google.common.truth.Truth.assertThat import org.junit.Before +import org.junit.Ignore import org.junit.Rule import org.junit.Test import org.junit.runner.RunWith @@ -86,6 +87,7 @@ class DataUsageLibTest { } @Test + @Ignore("b/297923588") fun getMobileTemplate_mergedImsisFromGroupNull_returnRequestedSub() { whenever(subscriptionManager.availableSubscriptionInfoList) .thenReturn(listOf(SUBSCRIBER_INFO)) @@ -168,4 +170,4 @@ class DataUsageLibTest { const val SUBSCRIBER_ID = "Test Subscriber" val SUBSCRIBER_INFO: SubscriptionInfo = SubscriptionInfo.Builder().setId(SUB_ID).build() } -} \ No newline at end of file +}