Do not turn on NFC automatically when airplane mode is off.
- besides checking the value for AIRPLANE_MODE_TOGGLEABLE_RADIOS, also check the value for AIRPLANE_MODE_RADIOS to determine if we should turn off NFC when airplane mode is on. - when user turns off airplane mode, only re-enable the NFC preference and do not enable NFC by default. - remove listening to airplane mode directly from the android beam preference controller, as it is already listening to Nfc state, which handles the beam state already. Change-Id: Id41fef15fb2de873729d20d7f53b1a88b164cf95 Fixes: 80217047 Test: make RunSettingsRoboTests
This commit is contained in:
@@ -17,7 +17,6 @@ package com.android.settings.nfc;
|
||||
|
||||
import android.content.Context;
|
||||
import android.nfc.NfcAdapter;
|
||||
import androidx.preference.Preference;
|
||||
import androidx.preference.PreferenceScreen;
|
||||
|
||||
import com.android.settings.core.BasePreferenceController;
|
||||
@@ -26,15 +25,12 @@ import com.android.settingslib.core.lifecycle.LifecycleObserver;
|
||||
import com.android.settingslib.core.lifecycle.events.OnPause;
|
||||
import com.android.settingslib.core.lifecycle.events.OnResume;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
public class AndroidBeamPreferenceController extends BasePreferenceController
|
||||
implements LifecycleObserver, OnResume, OnPause {
|
||||
|
||||
public static final String KEY_ANDROID_BEAM_SETTINGS = "android_beam_settings";
|
||||
private final NfcAdapter mNfcAdapter;
|
||||
private AndroidBeamEnabler mAndroidBeamEnabler;
|
||||
private NfcAirplaneModeObserver mAirplaneModeObserver;
|
||||
|
||||
public AndroidBeamPreferenceController(Context context, String key) {
|
||||
super(context, key);
|
||||
@@ -52,12 +48,6 @@ public class AndroidBeamPreferenceController extends BasePreferenceController
|
||||
final RestrictedPreference restrictedPreference =
|
||||
(RestrictedPreference) screen.findPreference(getPreferenceKey());
|
||||
mAndroidBeamEnabler = new AndroidBeamEnabler(mContext, restrictedPreference);
|
||||
|
||||
// Manually set dependencies for NFC when not toggleable.
|
||||
if (!NfcPreferenceController.isToggleableInAirplaneMode(mContext)) {
|
||||
mAirplaneModeObserver = new NfcAirplaneModeObserver(mContext, mNfcAdapter,
|
||||
(Preference) restrictedPreference);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -70,9 +60,6 @@ public class AndroidBeamPreferenceController extends BasePreferenceController
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
if (mAirplaneModeObserver != null) {
|
||||
mAirplaneModeObserver.register();
|
||||
}
|
||||
if (mAndroidBeamEnabler != null) {
|
||||
mAndroidBeamEnabler.resume();
|
||||
}
|
||||
@@ -80,9 +67,6 @@ public class AndroidBeamPreferenceController extends BasePreferenceController
|
||||
|
||||
@Override
|
||||
public void onPause() {
|
||||
if (mAirplaneModeObserver != null) {
|
||||
mAirplaneModeObserver.unregister();
|
||||
}
|
||||
if (mAndroidBeamEnabler != null) {
|
||||
mAndroidBeamEnabler.pause();
|
||||
}
|
||||
|
Reference in New Issue
Block a user