From e832c153c0ccdbe8094946d5e2c3acf5aaafe197 Mon Sep 17 00:00:00 2001 From: Bookatz Date: Tue, 10 Apr 2018 17:40:42 -0700 Subject: [PATCH] Fuelgauge handle StatsManager Exception API StatsManager now returns Exceptions for certain errors, instead of returning a boolean. Thus Fuelgauge needs to be updated. Bug: 77648233 Test: make ROBOTEST_FILTER=AnomalyConfigJobServiceTest RunSettingsRoboTests Change-Id: I7160ac01141c673c90e33423220dc888a2710340 --- .../batterytip/AnomalyConfigJobService.java | 33 +++++++++++-------- .../batterytip/AnomalyConfigReceiver.java | 6 +++- .../fuelgauge/batterytip/BatteryTipUtils.java | 8 +++-- .../AnomalyConfigJobServiceTest.java | 10 +++--- 4 files changed, 36 insertions(+), 21 deletions(-) diff --git a/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobService.java b/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobService.java index 5686d6e0aea..eb1e98341eb 100644 --- a/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobService.java +++ b/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobService.java @@ -71,7 +71,11 @@ public class AnomalyConfigJobService extends JobService { ThreadUtils.postOnBackgroundThread(() -> { final StatsManager statsManager = getSystemService(StatsManager.class); checkAnomalyConfig(statsManager); - BatteryTipUtils.uploadAnomalyPendingIntent(this, statsManager); + try { + BatteryTipUtils.uploadAnomalyPendingIntent(this, statsManager); + } catch (StatsManager.StatsUnavailableException e) { + Log.w(TAG, "Failed to uploadAnomalyPendingIntent.", e); + } jobFinished(params, false /* wantsReschedule */); }); @@ -96,23 +100,26 @@ public class AnomalyConfigJobService extends JobService { Log.i(TAG, "CurrentVersion: " + currentVersion + " new version: " + newVersion); if (newVersion > currentVersion) { - statsManager.removeConfiguration(StatsManagerConfig.ANOMALY_CONFIG_KEY); + try { + statsManager.removeConfig(StatsManagerConfig.ANOMALY_CONFIG_KEY); + } catch (StatsManager.StatsUnavailableException e) { + Log.i(TAG, "When updating anomaly config, failed to first remove the old config " + + StatsManagerConfig.ANOMALY_CONFIG_KEY, e); + } if (!TextUtils.isEmpty(rawConfig)) { try { final byte[] config = Base64.decode(rawConfig, Base64.DEFAULT); - if (statsManager.addConfiguration(StatsManagerConfig.ANOMALY_CONFIG_KEY, - config)) { - Log.i(TAG, "Upload the anomaly config. configKey: " - + StatsManagerConfig.ANOMALY_CONFIG_KEY); - SharedPreferences.Editor editor = sharedPreferences.edit(); - editor.putInt(KEY_ANOMALY_CONFIG_VERSION, newVersion); - editor.commit(); - } else { - Log.i(TAG, "Upload the anomaly config failed. configKey: " - + StatsManagerConfig.ANOMALY_CONFIG_KEY); - } + statsManager.addConfig(StatsManagerConfig.ANOMALY_CONFIG_KEY, config); + Log.i(TAG, "Upload the anomaly config. configKey: " + + StatsManagerConfig.ANOMALY_CONFIG_KEY); + SharedPreferences.Editor editor = sharedPreferences.edit(); + editor.putInt(KEY_ANOMALY_CONFIG_VERSION, newVersion); + editor.commit(); } catch (IllegalArgumentException e) { Log.e(TAG, "Anomaly raw config is in wrong format", e); + } catch (StatsManager.StatsUnavailableException e) { + Log.i(TAG, "Upload of anomaly config failed for configKey " + + StatsManagerConfig.ANOMALY_CONFIG_KEY, e); } } } diff --git a/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigReceiver.java b/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigReceiver.java index bad1c11b4fb..8e224470221 100644 --- a/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigReceiver.java +++ b/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigReceiver.java @@ -41,7 +41,11 @@ public class AnomalyConfigReceiver extends BroadcastReceiver { // Check whether to update the config AnomalyConfigJobService.scheduleConfigUpdate(context); - BatteryTipUtils.uploadAnomalyPendingIntent(context, statsManager); + try { + BatteryTipUtils.uploadAnomalyPendingIntent(context, statsManager); + } catch (StatsManager.StatsUnavailableException e) { + Log.w(TAG, "Failed to uploadAnomalyPendingIntent.", e); + } if (Intent.ACTION_BOOT_COMPLETED.equals(intent.getAction())) { AnomalyCleanupJobService.scheduleCleanUp(context); diff --git a/src/com/android/settings/fuelgauge/batterytip/BatteryTipUtils.java b/src/com/android/settings/fuelgauge/batterytip/BatteryTipUtils.java index a9e0fc87fa9..98ff244b0b8 100644 --- a/src/com/android/settings/fuelgauge/batterytip/BatteryTipUtils.java +++ b/src/com/android/settings/fuelgauge/batterytip/BatteryTipUtils.java @@ -110,12 +110,14 @@ public class BatteryTipUtils { /** * Upload the {@link PendingIntent} to {@link StatsManager} for anomaly detection + * @throws StatsManager.StatsUnavailableException if failed to communicate with stats service */ - public static void uploadAnomalyPendingIntent(Context context, StatsManager statsManager) { + public static void uploadAnomalyPendingIntent(Context context, StatsManager statsManager) + throws StatsManager.StatsUnavailableException { final Intent extraIntent = new Intent(context, AnomalyDetectionReceiver.class); final PendingIntent pendingIntent = PendingIntent.getBroadcast(context, REQUEST_CODE, extraIntent, PendingIntent.FLAG_UPDATE_CURRENT); - statsManager.setBroadcastSubscriber(StatsManagerConfig.ANOMALY_CONFIG_KEY, - StatsManagerConfig.SUBSCRIBER_ID, pendingIntent); + statsManager.setBroadcastSubscriber(pendingIntent, + StatsManagerConfig.ANOMALY_CONFIG_KEY, StatsManagerConfig.SUBSCRIBER_ID); } } diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobServiceTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobServiceTest.java index 90af7b17c2a..35b6531a5b3 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobServiceTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/AnomalyConfigJobServiceTest.java @@ -104,7 +104,8 @@ public class AnomalyConfigJobServiceTest { } @Test - public void checkAnomalyConfig_newConfigExist_removeOldConfig() { + public void checkAnomalyConfig_newConfigExist_removeOldConfig() + throws StatsManager.StatsUnavailableException{ Settings.Global.putInt(application.getContentResolver(), Settings.Global.ANOMALY_CONFIG_VERSION, ANOMALY_CONFIG_VERSION); Settings.Global.putString(application.getContentResolver(), Settings.Global.ANOMALY_CONFIG, @@ -112,11 +113,12 @@ public class AnomalyConfigJobServiceTest { mJobService.checkAnomalyConfig(mStatsManager); - verify(mStatsManager).removeConfiguration(StatsManagerConfig.ANOMALY_CONFIG_KEY); + verify(mStatsManager).removeConfig(StatsManagerConfig.ANOMALY_CONFIG_KEY); } @Test - public void checkAnomalyConfig_newConfigExist_uploadNewConfig() { + public void checkAnomalyConfig_newConfigExist_uploadNewConfig() + throws StatsManager.StatsUnavailableException{ Settings.Global.putInt(application.getContentResolver(), Settings.Global.ANOMALY_CONFIG_VERSION, ANOMALY_CONFIG_VERSION); Settings.Global.putString(application.getContentResolver(), Settings.Global.ANOMALY_CONFIG, @@ -124,7 +126,7 @@ public class AnomalyConfigJobServiceTest { mJobService.checkAnomalyConfig(mStatsManager); - verify(mStatsManager).addConfiguration(eq(StatsManagerConfig.ANOMALY_CONFIG_KEY), any()); + verify(mStatsManager).addConfig(eq(StatsManagerConfig.ANOMALY_CONFIG_KEY), any()); } }