diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 303dea1761a..c1e0c608a2a 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -307,7 +307,7 @@ + android:value="com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings" /> diff --git a/res/drawable/ic_menu_add_inset.xml b/res/drawable/ic_menu_add_inset.xml deleted file mode 100644 index a4f0a654660..00000000000 --- a/res/drawable/ic_menu_add_inset.xml +++ /dev/null @@ -1,29 +0,0 @@ - - - - - - diff --git a/res/xml/wifi_settings.xml b/res/xml/wifi_settings.xml index 52aadcfdceb..4ca92849788 100644 --- a/res/xml/wifi_settings.xml +++ b/res/xml/wifi_settings.xml @@ -39,6 +39,6 @@ + android:fragment="com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings" /> diff --git a/src/com/android/settings/core/gateway/SettingsGateway.java b/src/com/android/settings/core/gateway/SettingsGateway.java index 1569ff0eae8..219c92c5a6f 100644 --- a/src/com/android/settings/core/gateway/SettingsGateway.java +++ b/src/com/android/settings/core/gateway/SettingsGateway.java @@ -38,7 +38,6 @@ import com.android.settings.applications.DirectoryAccessDetails; import com.android.settings.applications.ProcessStatsSummary; import com.android.settings.applications.ProcessStatsUi; import com.android.settings.applications.UsageAccessDetails; -import com.android.settings.applications.specialaccess.vrlistener.VrListenerSettings; import com.android.settings.applications.appinfo.AppInfoDashboardFragment; import com.android.settings.applications.appinfo.DrawOverlayDetails; import com.android.settings.applications.appinfo.ExternalSourcesDetails; @@ -50,6 +49,7 @@ import com.android.settings.applications.managedomainurls.ManageDomainUrls; import com.android.settings.applications.specialaccess.deviceadmin.DeviceAdminSettings; import com.android.settings.applications.specialaccess.pictureinpicture.PictureInPictureDetails; import com.android.settings.applications.specialaccess.pictureinpicture.PictureInPictureSettings; +import com.android.settings.applications.specialaccess.vrlistener.VrListenerSettings; import com.android.settings.backup.PrivacySettings; import com.android.settings.backup.ToggleBackupSettingFragment; import com.android.settings.bluetooth.BluetoothDeviceDetailsFragment; @@ -127,12 +127,12 @@ import com.android.settings.wallpaper.WallpaperTypeSettings; import com.android.settings.webview.WebViewAppPicker; import com.android.settings.wfd.WifiDisplaySettings; import com.android.settings.wifi.ConfigureWifiSettings; -import com.android.settings.wifi.SavedAccessPointsWifiSettings; import com.android.settings.wifi.WifiAPITest; import com.android.settings.wifi.WifiInfo; import com.android.settings.wifi.WifiSettings; import com.android.settings.wifi.calling.WifiCallingSettings; import com.android.settings.wifi.p2p.WifiP2pSettings; +import com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings; import com.android.settings.wifi.tether.WifiTetherSettings; public class SettingsGateway { diff --git a/src/com/android/settings/wifi/LongPressAccessPointPreference.java b/src/com/android/settings/wifi/LongPressAccessPointPreference.java index 579d8487b7c..85fd800d912 100644 --- a/src/com/android/settings/wifi/LongPressAccessPointPreference.java +++ b/src/com/android/settings/wifi/LongPressAccessPointPreference.java @@ -27,12 +27,6 @@ public class LongPressAccessPointPreference extends AccessPointPreference { private final Fragment mFragment; - public LongPressAccessPointPreference(AccessPoint accessPoint, Context context, - UserBadgeCache cache, boolean forSavedNetworks, Fragment fragment) { - super(accessPoint, context, cache, forSavedNetworks); - mFragment = fragment; - } - public LongPressAccessPointPreference(AccessPoint accessPoint, Context context, UserBadgeCache cache, boolean forSavedNetworks, int iconResId, Fragment fragment) { super(accessPoint, context, cache, iconResId, forSavedNetworks); diff --git a/src/com/android/settings/wifi/WifiPickerActivity.java b/src/com/android/settings/wifi/WifiPickerActivity.java index ca392ce534d..f7c4f7936bd 100644 --- a/src/com/android/settings/wifi/WifiPickerActivity.java +++ b/src/com/android/settings/wifi/WifiPickerActivity.java @@ -21,6 +21,7 @@ import com.android.settings.ButtonBarHandler; import com.android.settings.R; import com.android.settings.SettingsActivity; import com.android.settings.wifi.p2p.WifiP2pSettings; +import com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings; import androidx.preference.PreferenceFragmentCompat; diff --git a/src/com/android/settings/wifi/WifiSettings.java b/src/com/android/settings/wifi/WifiSettings.java index e5ff3d97b07..28e10b2da6c 100644 --- a/src/com/android/settings/wifi/WifiSettings.java +++ b/src/com/android/settings/wifi/WifiSettings.java @@ -231,7 +231,7 @@ public class WifiSettings extends RestrictedSettingsFragment Context prefContext = getPrefContext(); mAddPreference = new Preference(prefContext); - mAddPreference.setIcon(R.drawable.ic_menu_add_inset); + mAddPreference.setIcon(R.drawable.ic_menu_add); mAddPreference.setTitle(R.string.wifi_add_network); mStatusMessagePreference = new LinkablePreference(prefContext); diff --git a/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java b/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettings.java similarity index 88% rename from src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java rename to src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettings.java index ebb493c2844..eeb5ca9d81d 100644 --- a/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java +++ b/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettings.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.android.settings.wifi; +package com.android.settings.wifi.savedaccesspoints; import android.annotation.Nullable; import android.app.Activity; @@ -26,30 +26,29 @@ import android.os.Bundle; import android.os.Handler; import android.util.Log; import android.widget.Toast; - +import androidx.annotation.VisibleForTesting; +import androidx.preference.Preference; +import androidx.preference.PreferenceScreen; import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto.MetricsEvent; import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; -import com.android.settings.search.Indexable; +import com.android.settings.wifi.WifiConfigUiBase; +import com.android.settings.wifi.WifiDialog; +import com.android.settings.wifi.WifiSettings; import com.android.settingslib.wifi.AccessPoint; import com.android.settingslib.wifi.AccessPointPreference; import com.android.settingslib.wifi.WifiSavedConfigUtils; - import java.util.Collections; import java.util.Comparator; import java.util.List; -import androidx.annotation.VisibleForTesting; -import androidx.preference.Preference; -import androidx.preference.PreferenceScreen; - /** * UI to manage saved networks/access points. * TODO(b/64806699): convert to {@link DashboardFragment} with {@link PreferenceController}s */ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment - implements Indexable, WifiDialog.WifiDialogListener { + implements WifiDialog.WifiDialogListener { private static final String TAG = "SavedAccessPoints"; @VisibleForTesting static final int MSG_UPDATE_PREFERENCES = 1; @@ -111,7 +110,6 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment private AccessPoint mDlgAccessPoint; private Bundle mAccessPointSavedState; private AccessPoint mSelectedAccessPoint; - private Preference mAddNetworkPreference; private AccessPointPreference.UserBadgeCache mUserBadgeCache; @@ -139,7 +137,8 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment @Override public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); - mWifiManager = (WifiManager) getSystemService(Context.WIFI_SERVICE); + mWifiManager = (WifiManager) getContext() + .getApplicationContext().getSystemService(Context.WIFI_SERVICE); if (savedInstanceState != null) { if (savedInstanceState.containsKey(SAVE_DIALOG_ACCESS_POINT_STATE)) { @@ -162,11 +161,10 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment for (int i = 0; i < accessPointsSize; ++i) { AccessPoint ap = accessPoints.get(i); String key = ap.getKey(); - LongPressAccessPointPreference preference = - (LongPressAccessPointPreference) getCachedPreference(key); + AccessPointPreference preference = + (AccessPointPreference) getCachedPreference(key); if (preference == null) { - preference = new LongPressAccessPointPreference( - ap, context, mUserBadgeCache, true, this); + preference = new AccessPointPreference(ap, context, mUserBadgeCache, true); preference.setKey(key); preference.setIcon(null); preferenceScreen.addPreference(preference); @@ -176,14 +174,6 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment removeCachedPrefs(preferenceScreen); - if (mAddNetworkPreference == null) { - mAddNetworkPreference = new Preference(getPrefContext()); - mAddNetworkPreference.setIcon(R.drawable.ic_menu_add_inset); - mAddNetworkPreference.setTitle(R.string.wifi_add_network); - } - mAddNetworkPreference.setOrder(accessPointsSize); - preferenceScreen.addPreference(mAddNetworkPreference); - if(getPreferenceScreen().getPreferenceCount() < 1) { Log.w(TAG, "Saved networks activity loaded, but there are no saved networks!"); } @@ -195,7 +185,7 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment } } - private void showWifiDialog(@Nullable LongPressAccessPointPreference accessPoint) { + private void showWifiDialog(@Nullable AccessPointPreference accessPoint) { if (mDialog != null) { removeDialog(WifiSettings.WIFI_DIALOG_ID); mDialog = null; @@ -290,11 +280,8 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment @Override public boolean onPreferenceTreeClick(Preference preference) { - if (preference instanceof LongPressAccessPointPreference) { - showWifiDialog((LongPressAccessPointPreference) preference); - return true; - } else if (preference == mAddNetworkPreference) { - showWifiDialog(null); + if (preference instanceof AccessPointPreference) { + showWifiDialog((AccessPointPreference) preference); return true; } else { return super.onPreferenceTreeClick(preference); diff --git a/tests/robotests/assets/grandfather_not_implementing_index_provider b/tests/robotests/assets/grandfather_not_implementing_index_provider index 48c9de94d8b..37869e97cf2 100644 --- a/tests/robotests/assets/grandfather_not_implementing_index_provider +++ b/tests/robotests/assets/grandfather_not_implementing_index_provider @@ -73,5 +73,5 @@ com.android.settings.wifi.calling.WifiCallingSettingsForSub com.android.settings.wifi.ChangeWifiStateDetails com.android.settings.wifi.details.WifiNetworkDetailsFragment com.android.settings.wifi.p2p.WifiP2pSettings -com.android.settings.wifi.SavedAccessPointsWifiSettings +com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings com.android.settings.wifi.WifiInfo diff --git a/tests/robotests/src/com/android/settings/wifi/SavedAccessPointsWifiSettingsTest.java b/tests/robotests/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettingsTest.java similarity index 96% rename from tests/robotests/src/com/android/settings/wifi/SavedAccessPointsWifiSettingsTest.java rename to tests/robotests/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettingsTest.java index b4fc4cdde7c..8ce2a3332f7 100644 --- a/tests/robotests/src/com/android/settings/wifi/SavedAccessPointsWifiSettingsTest.java +++ b/tests/robotests/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsWifiSettingsTest.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.android.settings.wifi; +package com.android.settings.wifi.savedaccesspoints; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.eq; @@ -28,6 +28,8 @@ import android.net.wifi.WifiManager.ActionListener; import android.os.Handler; import com.android.settings.testutils.SettingsRobolectricTestRunner; +import com.android.settings.wifi.WifiConfigController; +import com.android.settings.wifi.WifiDialog; import com.android.settingslib.wifi.AccessPoint; import org.junit.Before;