From 6542b6efb879c8ce4ad9c9ef27e79e6da3ede5ca Mon Sep 17 00:00:00 2001 From: Daniel Hsieh Date: Wed, 19 Jan 2022 08:58:28 +0000 Subject: [PATCH] Hide following typing preference setting in SuW. Hide following typing switch preference setting in SuW. Bug: 214876729 Test: Start set-up wizard > Assistive options > Vision settings > Magnification > Following typing preference is invisible make RunSettingsRoboTests ROBOTEST_FILTER= ToggleScreenMagnificationPreferenceFragmentTest Change-Id: I4ab64deeef321390c5b89c8ea58ea469fb5c09bf --- .../ToggleScreenMagnificationPreferenceFragment.java | 12 +++++++----- ...agnificationPreferenceFragmentForSetupWizard.java | 10 +++++++++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java index 08679180184..5f76d5a0a85 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java @@ -77,6 +77,8 @@ public class ToggleScreenMagnificationPreferenceFragment extends private DialogCreatable mDialogDelegate; private MagnificationFollowTypingPreferenceController mFollowTypingPreferenceController; + protected SwitchPreference mFollowingTypingSwitchPreference; + @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); @@ -178,15 +180,15 @@ public class ToggleScreenMagnificationPreferenceFragment extends getSettingsLifecycle().addObserver(magnificationModePreferenceController); magnificationModePreferenceController.displayPreference(getPreferenceScreen()); - final SwitchPreference followingTypingSwitchPreference = + mFollowingTypingSwitchPreference = new SwitchPreference(getPrefContext()); - followingTypingSwitchPreference.setTitle( + mFollowingTypingSwitchPreference.setTitle( R.string.accessibility_screen_magnification_follow_typing_title); - followingTypingSwitchPreference.setSummary( + mFollowingTypingSwitchPreference.setSummary( R.string.accessibility_screen_magnification_follow_typing_summary); - followingTypingSwitchPreference.setKey( + mFollowingTypingSwitchPreference.setKey( MagnificationFollowTypingPreferenceController.PREF_KEY); - generalCategory.addPreference(followingTypingSwitchPreference); + generalCategory.addPreference(mFollowingTypingSwitchPreference); mFollowTypingPreferenceController = new MagnificationFollowTypingPreferenceController( getContext(), MagnificationFollowTypingPreferenceController.PREF_KEY); diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java index 799508bfb0f..d92fd510056 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java @@ -44,9 +44,17 @@ public class ToggleScreenMagnificationPreferenceFragmentForSetupWizard final Drawable icon = getContext().getDrawable(R.drawable.ic_accessibility_visibility); AccessibilitySetupWizardUtils.updateGlifPreferenceLayout(getContext(), layout, title, description, icon); + hidePreferenceSettingComponents(); + } - // Hide the setting from the vision settings. + /** + * Hide the magnification preference settings in the SuW's vision settings. + */ + private void hidePreferenceSettingComponents() { + // Setting of magnification type mSettingsPreference.setVisible(false); + // Setting of following typing + mFollowingTypingSwitchPreference.setVisible(false); } @Override