Log visibility change for all fragments.
Bug: 30681771 Test: SettingsUnitTests Refactor visibility logging from InstrumentedFragment into a mixin. And apply mixin in remaining fragments. Change-Id: Ibbb59904336254a3e4bb9e8c7d0b36e5a6bc2622
This commit is contained in:
@@ -31,6 +31,9 @@ import android.view.ViewGroup;
|
||||
import android.widget.ListView;
|
||||
import android.widget.SimpleAdapter;
|
||||
|
||||
import com.android.internal.logging.MetricsProto;
|
||||
import com.android.settings.core.instrumentation.VisibilityLoggerMixin;
|
||||
import com.android.settings.core.instrumentation.Instrumentable;
|
||||
import com.android.settingslib.datetime.ZoneGetter;
|
||||
|
||||
import java.util.Collections;
|
||||
@@ -46,8 +49,7 @@ import java.util.TimeZone;
|
||||
* the time zone. Pressing Back without choosing from the list will not
|
||||
* result in a change in the time zone setting.
|
||||
*/
|
||||
public class ZonePicker extends ListFragment {
|
||||
private static final String TAG = "ZonePicker";
|
||||
public class ZonePicker extends ListFragment implements Instrumentable {
|
||||
|
||||
public interface ZoneSelectionListener {
|
||||
// You can add any argument if you really need it...
|
||||
@@ -56,6 +58,7 @@ public class ZonePicker extends ListFragment {
|
||||
|
||||
private static final int MENU_TIMEZONE = Menu.FIRST+1;
|
||||
private static final int MENU_ALPHABETICAL = Menu.FIRST;
|
||||
private final VisibilityLoggerMixin mVisibilityLoggerMixin = new VisibilityLoggerMixin(this);
|
||||
|
||||
private boolean mSortedByTimezone;
|
||||
|
||||
@@ -132,6 +135,11 @@ public class ZonePicker extends ListFragment {
|
||||
return TimeZone.getTimeZone((String)((Map<?, ?>)item).get(ZoneGetter.KEY_ID));
|
||||
}
|
||||
|
||||
@Override
|
||||
public int getMetricsCategory() {
|
||||
return MetricsProto.MetricsEvent.ZONE_PICKER;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onActivityCreated(Bundle savedInstanceState) {
|
||||
super.onActivityCreated(savedInstanceState);
|
||||
@@ -174,6 +182,12 @@ public class ZonePicker extends ListFragment {
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
super.onResume();
|
||||
mVisibilityLoggerMixin.onResume(getActivity());
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean onOptionsItemSelected(MenuItem item) {
|
||||
switch (item.getItemId()) {
|
||||
@@ -225,6 +239,12 @@ public class ZonePicker extends ListFragment {
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onPause() {
|
||||
super.onPause();
|
||||
mVisibilityLoggerMixin.onPause(getActivity());
|
||||
}
|
||||
|
||||
private static class MyComparator implements Comparator<Map<?, ?>> {
|
||||
private String mSortingKey;
|
||||
|
||||
|
Reference in New Issue
Block a user