From 8c543276f1dd366bd142ce44a8e3084fddb22971 Mon Sep 17 00:00:00 2001 From: Jorim Jaggi Date: Fri, 4 Sep 2015 11:42:28 -0700 Subject: [PATCH] Fix crash in fingerprint settings when rotating Fragments always need empty constructors. Bug: 23806551 Change-Id: Ib22a89be60f799d70caf1acf2ac95a20e6be9675 --- .../settings/fingerprint/FingerprintSettings.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/com/android/settings/fingerprint/FingerprintSettings.java b/src/com/android/settings/fingerprint/FingerprintSettings.java index 43c1e76fcd3..d9ec38d30f9 100644 --- a/src/com/android/settings/fingerprint/FingerprintSettings.java +++ b/src/com/android/settings/fingerprint/FingerprintSettings.java @@ -528,7 +528,6 @@ public class FingerprintSettings extends SubSettings { public static class RenameDeleteDialog extends DialogFragment { - private final Context mContext; private Fingerprint mFp; private EditText mDialogTextField; private String mFingerName; @@ -536,10 +535,6 @@ public class FingerprintSettings extends SubSettings { private int mTextSelectionStart; private int mTextSelectionEnd; - public RenameDeleteDialog(Context context) { - mContext = context; - } - @Override public Dialog onCreateDialog(Bundle savedInstanceState) { mFp = getArguments().getParcelable("fingerprint"); @@ -562,7 +557,7 @@ public class FingerprintSettings extends SubSettings { if (DEBUG) { Log.v(TAG, "rename " + name + " to " + newName); } - MetricsLogger.action(mContext, + MetricsLogger.action(getContext(), MetricsLogger.ACTION_FINGERPRINT_RENAME, mFp.getFingerId()); FingerprintSettingsFragment parent @@ -607,7 +602,7 @@ public class FingerprintSettings extends SubSettings { private void onDeleteClick(DialogInterface dialog) { if (DEBUG) Log.v(TAG, "Removing fpId=" + mFp.getFingerId()); - MetricsLogger.action(mContext, MetricsLogger.ACTION_FINGERPRINT_DELETE, + MetricsLogger.action(getContext(), MetricsLogger.ACTION_FINGERPRINT_DELETE, mFp.getFingerId()); FingerprintSettingsFragment parent = (FingerprintSettingsFragment) getTargetFragment();