PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize poking to happen in dashboard fragment

Browse Source 
- Make sure that poking happens only once in
 onDeveloperOptionsDisabled()

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2a47f34ab17bf57ac4dabc7b0e67b42cc0b120b7
This commit is contained in:
jeffreyhuang
2017-09-28 15:54:50 -07:00
parent ae6c29d10f
commit 64b66e6036
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java
View File

@@ -43,6 +43,7 @@ import com.android.settings.widget.SwitchBar;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.development.DevelopmentSettingsEnabler; import com.android.settingslib.development.DevelopmentSettingsEnabler;
import com.android.settingslib.development.SystemPropPoker;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
@@ -126,12 +127,16 @@ public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFra
EnableDevelopmentSettingWarningDialog.show(this /* host */); EnableDevelopmentSettingWarningDialog.show(this /* host */);
} else { } else {
DevelopmentSettingsEnabler.setDevelopmentSettingsEnabled(getContext(), false); DevelopmentSettingsEnabler.setDevelopmentSettingsEnabled(getContext(), false);
final SystemPropPoker poker = SystemPropPoker.getInstance();
poker.blockPokes();
for (AbstractPreferenceController controller : mPreferenceControllers) { for (AbstractPreferenceController controller : mPreferenceControllers) {
if (controller instanceof DeveloperOptionsPreferenceController) { if (controller instanceof DeveloperOptionsPreferenceController) {
((DeveloperOptionsPreferenceController) controller) ((DeveloperOptionsPreferenceController) controller)
.onDeveloperOptionsDisabled(); .onDeveloperOptionsDisabled();
} }
} }
poker.unblockPokes();
poker.poke();
} }
} }
} }