From 8b1f85aaac0626f06c14fcaa591010002e5360b8 Mon Sep 17 00:00:00 2001 From: Angela Wang Date: Mon, 10 Apr 2023 08:49:07 +0000 Subject: [PATCH] Logs Flash Notifications toggle event Logs the toggle event of different kind of flash notification to better know about how many usage of these feature and make it as our success metrics. Bug: 277552681 Test: m statsd_testdrive && statsd_testdrive 513, checks the metrics manually Change-Id: I73068744b7eef391ee459314da21c23cf64ef212 --- .../CameraFlashNotificationPreferenceController.java | 4 +++- .../ScreenFlashNotificationPreferenceController.java | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/accessibility/CameraFlashNotificationPreferenceController.java b/src/com/android/settings/accessibility/CameraFlashNotificationPreferenceController.java index f19795fa8de..8b9b8883294 100644 --- a/src/com/android/settings/accessibility/CameraFlashNotificationPreferenceController.java +++ b/src/com/android/settings/accessibility/CameraFlashNotificationPreferenceController.java @@ -24,7 +24,7 @@ import android.provider.Settings; import com.android.settings.R; import com.android.settings.core.TogglePreferenceController; - +import com.android.settings.overlay.FeatureFactory; /** * Controller for Camera flash notification. @@ -49,6 +49,8 @@ public class CameraFlashNotificationPreferenceController extends TogglePreferenc @Override public boolean setChecked(boolean isChecked) { + FeatureFactory.getFactory(mContext).getMetricsFeatureProvider().changed( + getMetricsCategory(), getPreferenceKey(), isChecked ? 1 : 0); return Settings.System.putInt(mContext.getContentResolver(), Settings.System.CAMERA_FLASH_NOTIFICATION, (isChecked ? ON : OFF)); } diff --git a/src/com/android/settings/accessibility/ScreenFlashNotificationPreferenceController.java b/src/com/android/settings/accessibility/ScreenFlashNotificationPreferenceController.java index 2b96dcffb86..53abc95efb7 100644 --- a/src/com/android/settings/accessibility/ScreenFlashNotificationPreferenceController.java +++ b/src/com/android/settings/accessibility/ScreenFlashNotificationPreferenceController.java @@ -30,6 +30,7 @@ import androidx.preference.PreferenceScreen; import com.android.settings.R; import com.android.settings.core.TogglePreferenceController; +import com.android.settings.overlay.FeatureFactory; import java.util.function.Consumer; @@ -62,8 +63,11 @@ public class ScreenFlashNotificationPreferenceController extends TogglePreferenc @Override public boolean setChecked(boolean isChecked) { - if (isChecked) checkAndSetInitialColor(); - + FeatureFactory.getFactory(mContext).getMetricsFeatureProvider().changed( + getMetricsCategory(), getPreferenceKey(), isChecked ? 1 : 0); + if (isChecked) { + checkAndSetInitialColor(); + } return Settings.System.putInt(mContext.getContentResolver(), Settings.System.SCREEN_FLASH_NOTIFICATION, (isChecked ? ON : OFF)); }