From 6438ee5466c72155bcf7e68127f54de1b47e2edc Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Tue, 31 Oct 2017 14:02:06 -0700 Subject: [PATCH] Mark core unit tests for Presubmit Bug: 68716631 Bug: 68720368 Test: rerun test Change-Id: Ia8cca6aede824928fc358b005172bbe2ed670c8f --- tests/anomaly-tester/res/values/strings.xml | 2 +- tests/unit/Android.mk | 10 +++++----- .../core/PreferenceControllerContractTest.java | 2 ++ .../android/settings/core/UniquePreferenceTest.java | 2 ++ 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/anomaly-tester/res/values/strings.xml b/tests/anomaly-tester/res/values/strings.xml index 99de34e62dd..da5635698c6 100644 --- a/tests/anomaly-tester/res/values/strings.xml +++ b/tests/anomaly-tester/res/values/strings.xml @@ -15,5 +15,5 @@ --> - AnomalyTester + AnomalyTester diff --git a/tests/unit/Android.mk b/tests/unit/Android.mk index ec0f0b6662c..58fe7dd1d21 100644 --- a/tests/unit/Android.mk +++ b/tests/unit/Android.mk @@ -10,13 +10,13 @@ LOCAL_JAVA_LIBRARIES := android.test.runner telephony-common ims-common LOCAL_STATIC_JAVA_LIBRARIES := \ android-support-test \ espresso-core \ - legacy-android-test \ - mockito-target-minus-junit4 \ - truth-prebuilt \ - ub-uiautomator \ espresso-contrib-nodep \ espresso-intents-nodep \ - + legacy-android-test \ + mockito-target-minus-junit4 \ + platform-test-annotations \ + truth-prebuilt \ + ub-uiautomator # Include all test java files. LOCAL_SRC_FILES := $(call all-java-files-under, src) diff --git a/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java b/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java index 322f328f410..c75ca132048 100644 --- a/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java +++ b/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java @@ -19,6 +19,7 @@ package com.android.settings.core; import static junit.framework.Assert.fail; import android.content.Context; +import android.platform.test.annotations.Presubmit; import android.provider.SearchIndexableResource; import android.support.test.InstrumentationRegistry; import android.support.test.filters.MediumTest; @@ -49,6 +50,7 @@ public class PreferenceControllerContractTest { } @Test + @Presubmit public void controllersInSearchShouldImplementPreferenceControllerMixin() { final Set errorClasses = new ArraySet<>(); diff --git a/tests/unit/src/com/android/settings/core/UniquePreferenceTest.java b/tests/unit/src/com/android/settings/core/UniquePreferenceTest.java index 5be9a365e00..4c5177235c4 100644 --- a/tests/unit/src/com/android/settings/core/UniquePreferenceTest.java +++ b/tests/unit/src/com/android/settings/core/UniquePreferenceTest.java @@ -21,6 +21,7 @@ import static junit.framework.Assert.fail; import android.content.Context; import android.content.res.Resources; import android.content.res.XmlResourceParser; +import android.platform.test.annotations.Presubmit; import android.provider.SearchIndexableResource; import android.support.test.InstrumentationRegistry; import android.support.test.filters.MediumTest; @@ -83,6 +84,7 @@ public class UniquePreferenceTest { * should have a key. */ @Test + @Presubmit public void allPreferencesShouldHaveUniqueKey() throws IOException, XmlPullParserException, Resources.NotFoundException { final Set uniqueKeys = new HashSet<>();