From a875924100fb719859e2c95f20923d8df7c852d9 Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Fri, 6 Jan 2017 09:18:59 -0800 Subject: [PATCH] Wrap old search index update logic behind FeatureProvider. Change-Id: I31024d2e7900a90b4f7dc8cc81951bf6a0e533fa Fix: 34123028 Test: RunSettingsRoboTests --- src/com/android/settings/SettingsActivity.java | 5 +---- .../settings/search2/SearchFeatureProviderImpl.java | 8 ++++++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index 179e3522145..d5920e52583 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -462,10 +462,7 @@ public class SettingsActivity extends SettingsDrawerActivity if (mIsShowingDashboard) { // Run the Index update only if we have some space if (!Utils.isLowStorage(this)) { - long indexStartTime = System.currentTimeMillis(); - Index.getInstance(getApplicationContext()).update(); - if (DEBUG_TIMING) Log.d(LOG_TAG, "Index.update() took " - + (System.currentTimeMillis() - indexStartTime) + " ms"); + mSearchFeatureProvider.updateIndex(getApplicationContext()); } else { Log.w(LOG_TAG, "Cannot update the Indexer as we are running low on storage space!"); } diff --git a/src/com/android/settings/search2/SearchFeatureProviderImpl.java b/src/com/android/settings/search2/SearchFeatureProviderImpl.java index 5aa21dfedeb..97b7bfe0d13 100644 --- a/src/com/android/settings/search2/SearchFeatureProviderImpl.java +++ b/src/com/android/settings/search2/SearchFeatureProviderImpl.java @@ -19,19 +19,21 @@ package com.android.settings.search2; import android.app.Activity; import android.content.Context; import android.content.Intent; +import android.util.Log; import android.view.Menu; import android.view.MenuItem; import com.android.settings.R; -import com.android.settings.search.Index; - import com.android.settings.applications.PackageManagerWrapperImpl; +import com.android.settings.search.Index; /** * FeatureProvider for the refactored search code. */ public class SearchFeatureProviderImpl implements SearchFeatureProvider { + private static final String TAG = "SearchFeatureProvider"; + private DatabaseIndexingManager mDatabaseIndexingManager; @Override @@ -81,10 +83,12 @@ public class SearchFeatureProviderImpl implements SearchFeatureProvider { @Override public void updateIndex(Context context) { + long indexStartTime = System.currentTimeMillis(); if (isEnabled(context)) { getIndexingManager(context).update(); } else { Index.getInstance(context).update(); } + Log.d(TAG, "Index.update() took " + (System.currentTimeMillis() - indexStartTime) + " ms"); } }