From d13b50b39e3516fef0afdf8b7125351d3f0ffe78 Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Thu, 29 Nov 2018 13:18:21 -0800 Subject: [PATCH] Remove the 2 seconds wait time to sync app data usage list. - in v2, completely remove the asyn task to force update the network stats since the network stats apis is actually not used. - in v1, remove the 2s delay and only update the list when the asyn task is done. Change-Id: I10e887022d07fe38504036cbf3f12362eec939b3 Fixes: 119562454 Test: manual --- .../settings/datausage/DataUsageList.java | 8 +------ .../settings/datausage/DataUsageListV2.java | 22 ------------------- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/src/com/android/settings/datausage/DataUsageList.java b/src/com/android/settings/datausage/DataUsageList.java index 8f0026f4e1e..24192cd02e7 100644 --- a/src/com/android/settings/datausage/DataUsageList.java +++ b/src/com/android/settings/datausage/DataUsageList.java @@ -193,17 +193,13 @@ public class DataUsageList extends DataUsageBaseFragment { public void onResume() { super.onResume(); mDataStateListener.setListener(true, mSubId, getContext()); - updateBody(); // kick off background task to update stats new AsyncTask() { @Override protected Void doInBackground(Void... params) { try { - // wait a few seconds before kicking off - Thread.sleep(2 * DateUtils.SECOND_IN_MILLIS); services.mStatsService.forceUpdate(); - } catch (InterruptedException e) { } catch (RemoteException e) { } return null; @@ -211,9 +207,7 @@ public class DataUsageList extends DataUsageBaseFragment { @Override protected void onPostExecute(Void result) { - if (isAdded()) { - updateBody(); - } + updateBody(); } }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR); } diff --git a/src/com/android/settings/datausage/DataUsageListV2.java b/src/com/android/settings/datausage/DataUsageListV2.java index 4432feec1be..3a71935a865 100644 --- a/src/com/android/settings/datausage/DataUsageListV2.java +++ b/src/com/android/settings/datausage/DataUsageListV2.java @@ -187,28 +187,6 @@ public class DataUsageListV2 extends DataUsageBaseFragment { super.onResume(); mDataStateListener.setListener(true, mSubId, getContext()); updateBody(); - - // kick off background task to update stats - new AsyncTask() { - @Override - protected Void doInBackground(Void... params) { - try { - // wait a few seconds before kicking off - Thread.sleep(2 * DateUtils.SECOND_IN_MILLIS); - services.mStatsService.forceUpdate(); - } catch (InterruptedException e) { - } catch (RemoteException e) { - } - return null; - } - - @Override - protected void onPostExecute(Void result) { - if (isAdded()) { - updateBody(); - } - } - }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR); } @Override