From d956175333c10b3033a62dd1d0c91ec40e194390 Mon Sep 17 00:00:00 2001
From: Shen Lin <shhenlin@gmail.com>
Date: Thu, 13 Oct 2022 17:09:32 +0800
Subject: [PATCH] Fix "show system apps" status lost when switching on/off dark
 theme

Bug: 253388290
Test: manual and atest
Change-Id: I5833f94478c2faaf53d40652f0e7ce92adb3e8b6
---
 .../datausage/UnrestrictedDataAccess.java     | 37 +++++++------------
 1 file changed, 13 insertions(+), 24 deletions(-)

diff --git a/src/com/android/settings/datausage/UnrestrictedDataAccess.java b/src/com/android/settings/datausage/UnrestrictedDataAccess.java
index 319ab6fe5a3..05c11327f73 100644
--- a/src/com/android/settings/datausage/UnrestrictedDataAccess.java
+++ b/src/com/android/settings/datausage/UnrestrictedDataAccess.java
@@ -27,7 +27,6 @@ import com.android.settings.dashboard.DashboardFragment;
 import com.android.settings.search.BaseSearchIndexProvider;
 import com.android.settingslib.applications.AppIconCacheManager;
 import com.android.settingslib.applications.ApplicationsState;
-import com.android.settingslib.applications.ApplicationsState.AppFilter;
 import com.android.settingslib.search.SearchIndexable;
 
 @SearchIndexable
@@ -39,14 +38,15 @@ public class UnrestrictedDataAccess extends DashboardFragment {
     private static final String EXTRA_SHOW_SYSTEM = "show_system";
 
     private boolean mShowSystem;
-    private AppFilter mFilter;
 
     @Override
     public void onCreate(Bundle icicle) {
         super.onCreate(icicle);
         mShowSystem = icicle != null && icicle.getBoolean(EXTRA_SHOW_SYSTEM);
-
-        use(UnrestrictedDataAccessPreferenceController.class).setParentFragment(this);
+        use(UnrestrictedDataAccessPreferenceController.class).setFilter(
+                mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
+                        : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER);
+        use(UnrestrictedDataAccessPreferenceController.class).setSession(getSettingsLifecycle());
     }
 
     @Override
@@ -58,17 +58,14 @@ public class UnrestrictedDataAccess extends DashboardFragment {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        switch (item.getItemId()) {
-            case MENU_SHOW_SYSTEM:
-                mShowSystem = !mShowSystem;
-                item.setTitle(mShowSystem ? R.string.menu_hide_system : R.string.menu_show_system);
-                mFilter = mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
-                        : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER;
-
-                use(UnrestrictedDataAccessPreferenceController.class).setFilter(mFilter);
-                use(UnrestrictedDataAccessPreferenceController.class).rebuild();
-
-                break;
+        if (item.getItemId() == MENU_SHOW_SYSTEM) {
+            mShowSystem = !mShowSystem;
+            item.setTitle(mShowSystem ? R.string.menu_hide_system : R.string.menu_show_system);
+            use(UnrestrictedDataAccessPreferenceController.class).setFilter(
+                    mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
+                            : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER);
+            use(UnrestrictedDataAccessPreferenceController.class).rebuild();
+            return true;
         }
         return super.onOptionsItemSelected(item);
     }
@@ -79,18 +76,10 @@ public class UnrestrictedDataAccess extends DashboardFragment {
         outState.putBoolean(EXTRA_SHOW_SYSTEM, mShowSystem);
     }
 
-    @Override
-    public void onViewCreated(View view, Bundle savedInstanceState) {
-        super.onViewCreated(view, savedInstanceState);
-    }
-
     @Override
     public void onAttach(Context context) {
         super.onAttach(context);
-        mFilter = mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
-                : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER;
-        use(UnrestrictedDataAccessPreferenceController.class).setSession(getSettingsLifecycle());
-        use(UnrestrictedDataAccessPreferenceController.class).setFilter(mFilter);
+        use(UnrestrictedDataAccessPreferenceController.class).setParentFragment(this);
     }
 
     @Override