Merge "Developer option off must not affect laser sensor"

This commit is contained in:
TreeHugger Robot
2019-09-23 15:07:13 +00:00
committed by Android (Google) Code Review
2 changed files with 3 additions and 18 deletions

View File

@@ -75,12 +75,9 @@ public class CameraLaserSensorPreferenceController extends DeveloperOptionsPrefe
((SwitchPreference) mPreference).setChecked(enabled); ((SwitchPreference) mPreference).setChecked(enabled);
} }
@Override // There should be no impact on the current
protected void onDeveloperOptionsSwitchDisabled() { // laser sensor settings in case the developer
super.onDeveloperOptionsSwitchDisabled(); // settings switch is turned on or off!
SystemProperties.set(PROPERTY_CAMERA_LASER_SENSOR, Integer.toString(DISABLED));
((SwitchPreference) mPreference).setChecked(false);
}
private boolean isLaserSensorEnabled() { private boolean isLaserSensorEnabled() {
final String prop = SystemProperties.get(PROPERTY_CAMERA_LASER_SENSOR, final String prop = SystemProperties.get(PROPERTY_CAMERA_LASER_SENSOR,

View File

@@ -128,16 +128,4 @@ public class CameraLaserSensorPreferenceControllerTest {
CameraLaserSensorPreferenceController.PROPERTY_CAMERA_LASER_SENSOR, CameraLaserSensorPreferenceController.PROPERTY_CAMERA_LASER_SENSOR,
Integer.toString(CameraLaserSensorPreferenceController.ENABLED))); Integer.toString(CameraLaserSensorPreferenceController.ENABLED)));
} }
@Test
public void onDeveloperOptionsSwitchDisabled_preferenceShouldBeEnabled() {
mController.onDeveloperOptionsSwitchDisabled();
verify(mPreference).setEnabled(false);
verify(mPreference).setChecked(false);
assertThat(Integer.toString(CameraLaserSensorPreferenceController.DISABLED)).isEqualTo(
SystemProperties.get(
CameraLaserSensorPreferenceController.PROPERTY_CAMERA_LASER_SENSOR,
Integer.toString(CameraLaserSensorPreferenceController.ENABLED)));
}
} }