diff --git a/res/xml/my_device_info.xml b/res/xml/my_device_info.xml index 29c3c62f1bf..62bc040da2f 100644 --- a/res/xml/my_device_info.xml +++ b/res/xml/my_device_info.xml @@ -52,11 +52,12 @@ settings:controller="com.android.settings.deviceinfo.BrandedAccountPreferenceController"/> - @@ -118,7 +119,6 @@ android:key="eid_info" android:order="31" android:title="@string/status_eid" - android:summary="@string/device_info_protected_single_press" android:positiveButtonText="@string/dlg_ok" android:dialogLayout="@layout/dialog_eid_status" settings:isPreferenceVisible="@bool/config_show_sim_info" @@ -126,7 +126,7 @@ settings:controller="com.android.settings.deviceinfo.simstatus.SimEidPreferenceController"/> - (R.id.esim_id_qrcode) qrCodeView.setImageBitmap(getEidQrCode(eid)) - - // After "Tap to show", eid is displayed on preference. - preference.summary = textView.text } override fun handlePreferenceTreeClick(preference: Preference): Boolean { diff --git a/tests/unit/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java b/tests/unit/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java index 5f02b04f7e0..9a5399c5f07 100644 --- a/tests/unit/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java @@ -37,7 +37,6 @@ import androidx.preference.PreferenceScreen; import androidx.test.core.app.ApplicationProvider; import androidx.test.ext.junit.runners.AndroidJUnit4; -import com.android.settings.core.BasePreferenceController; import com.android.settings.testutils.ResourcesUtils; import org.junit.Before; @@ -89,26 +88,9 @@ public class PhoneNumberPreferenceControllerTest { mCategory.setKey(categoryKey); mScreen.addPreference(mCategory); - doReturn(mSubscriptionInfo).when(mController).getSubscriptionInfo(anyInt()); doReturn(mSecondPreference).when(mController).createNewPreference(mContext); } - @Test - public void getAvailabilityStatus_isVoiceCapable_shouldBeAVAILABLE() { - when(mTelephonyManager.isVoiceCapable()).thenReturn(true); - - assertThat(mController.getAvailabilityStatus()).isEqualTo( - BasePreferenceController.AVAILABLE); - } - - @Test - public void getAvailabilityStatus_isNotVoiceCapable_shouldBeUNSUPPORTED_ON_DEVICE() { - when(mTelephonyManager.isVoiceCapable()).thenReturn(false); - - assertThat(mController.getAvailabilityStatus()).isEqualTo( - BasePreferenceController.UNSUPPORTED_ON_DEVICE); - } - @Test public void displayPreference_multiSim_shouldAddSecondPreference() { when(mTelephonyManager.getPhoneCount()).thenReturn(2); @@ -123,6 +105,7 @@ public class PhoneNumberPreferenceControllerTest { @Test public void updateState_singleSim_shouldUpdateTitleAndPhoneNumber() { final String phoneNumber = "1111111111"; + doReturn(mSubscriptionInfo).when(mController).getSubscriptionInfo(anyInt()); doReturn(phoneNumber).when(mController).getFormattedPhoneNumber(mSubscriptionInfo); when(mTelephonyManager.getPhoneCount()).thenReturn(1); mController.displayPreference(mScreen); @@ -136,6 +119,7 @@ public class PhoneNumberPreferenceControllerTest { @Test public void updateState_multiSim_shouldUpdateTitleAndPhoneNumberOfMultiplePreferences() { final String phoneNumber = "1111111111"; + doReturn(mSubscriptionInfo).when(mController).getSubscriptionInfo(anyInt()); doReturn(phoneNumber).when(mController).getFormattedPhoneNumber(mSubscriptionInfo); when(mTelephonyManager.getPhoneCount()).thenReturn(2); mController.displayPreference(mScreen); @@ -153,11 +137,11 @@ public class PhoneNumberPreferenceControllerTest { @Test public void getSummary_cannotGetActiveSubscriptionInfo_shouldShowUnknown() { when(mSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(null); + mController.displayPreference(mScreen); - CharSequence primaryNumber = mController.getSummary(); + mController.updateState(mPreference); - assertThat(primaryNumber).isNotNull(); - assertThat(primaryNumber).isEqualTo(ResourcesUtils.getResourcesString( + verify(mPreference).setSummary(ResourcesUtils.getResourcesString( mContext, "device_info_default")); } @@ -166,9 +150,10 @@ public class PhoneNumberPreferenceControllerTest { List infos = new ArrayList<>(); when(mSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(infos); - CharSequence primaryNumber = mController.getSummary(); + mController.displayPreference(mScreen); + mController.updateState(mPreference); - assertThat(primaryNumber).isEqualTo(ResourcesUtils.getResourcesString( + verify(mPreference).setSummary(ResourcesUtils.getResourcesString( mContext, "device_info_default")); } }