From 205bac7c267b9e7f68a02502a383cd87654f6e17 Mon Sep 17 00:00:00 2001 From: Hyunyoung Song Date: Mon, 22 Apr 2019 16:27:50 -0700 Subject: [PATCH] Reduce binder call to OverlayManager (3->1) Bug: 131112014 Test: builds, manually tested Change-Id: I1f0fba30a55713be92b8755c0793ee84928f9d5e --- .../SystemNavigationPreferenceController.java | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/com/android/settings/gestures/SystemNavigationPreferenceController.java b/src/com/android/settings/gestures/SystemNavigationPreferenceController.java index 5f58fcfa559..f2c8252be39 100644 --- a/src/com/android/settings/gestures/SystemNavigationPreferenceController.java +++ b/src/com/android/settings/gestures/SystemNavigationPreferenceController.java @@ -139,12 +139,11 @@ public abstract class SystemNavigationPreferenceController extends GesturePrefer * Enables the specified overlay package. */ static void setNavBarInteractionMode(IOverlayManager overlayManager, String overlayPackage) { - setOverlayEnabled(overlayManager, NAV_BAR_MODE_3BUTTON_OVERLAY, - overlayPackage == NAV_BAR_MODE_3BUTTON_OVERLAY); - setOverlayEnabled(overlayManager, NAV_BAR_MODE_2BUTTON_OVERLAY, - overlayPackage == NAV_BAR_MODE_2BUTTON_OVERLAY); - setOverlayEnabled(overlayManager, NAV_BAR_MODE_GESTURAL_OVERLAY, - overlayPackage == NAV_BAR_MODE_GESTURAL_OVERLAY); + try { + overlayManager.setEnabledExclusiveInCategory(overlayPackage, USER_CURRENT); + } catch (RemoteException e) { + throw e.rethrowFromSystemServer(); + } } static boolean isSwipeUpEnabled(Context context) { @@ -159,12 +158,4 @@ public abstract class SystemNavigationPreferenceController extends GesturePrefer return NAV_BAR_MODE_GESTURAL == context.getResources().getInteger( com.android.internal.R.integer.config_navBarInteractionMode); } - - static void setOverlayEnabled(IOverlayManager overlayManager, String pkg, boolean enabled) { - try { - overlayManager.setEnabled(pkg, enabled, USER_CURRENT); - } catch (RemoteException e) { - throw e.rethrowFromSystemServer(); - } - } }