PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Do not auto-downgrade WPA3->Transition mode if password too short" into main

Browse Source
This commit is contained in:
Quang Luong
2024-09-27 07:52:45 +00:00
committed by Android (Google) Code Review
parent ccaa62ec8a 5aa95553cd
commit 5f1b6be477
2 changed files with 33 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/com/android/settings/wifi/repository/WifiHotspotRepository.java
View File

@@ -356,10 +356,11 @@ public class WifiHotspotRepository {
log("setSpeedType(), setBand(BAND_2GHZ)"); log("setSpeedType(), setBand(BAND_2GHZ)");
configBuilder.setBand(BAND_2GHZ); configBuilder.setBand(BAND_2GHZ);
} }
// Set the security type back to WPA2/WPA3 if we're moving from 6GHz to something else. // Set the security type back to WPA2/WPA3 if the password is at least 8 characters and
if ((config.getBand() & BAND_6GHZ) != 0) { // we're moving from 6GHz to something else.
configBuilder.setPassphrase( String passphrase = generatePassword(config);
generatePassword(config), SECURITY_TYPE_WPA3_SAE_TRANSITION); if ((passphrase.length() >= 8) && (config.getBand() & BAND_6GHZ) != 0) {
configBuilder.setPassphrase(passphrase, SECURITY_TYPE_WPA3_SAE_TRANSITION);
} }
} }
setSoftApConfiguration(configBuilder.build()); setSoftApConfiguration(configBuilder.build());

33
tests/unit/src/com/android/settings/wifi/repository/WifiHotspotRepositoryTest.java
View File

@@ -78,6 +78,7 @@ import java.util.Arrays;
public class WifiHotspotRepositoryTest { public class WifiHotspotRepositoryTest {
static final String WIFI_SSID = "wifi_ssid"; static final String WIFI_SSID = "wifi_ssid";
static final String WIFI_PASSWORD = "wifi_password"; static final String WIFI_PASSWORD = "wifi_password";
static final String WIFI_PASSWORD_SHORT = "wifi";
static final int WIFI_5GHZ_BAND_PREFERRED = BAND_2GHZ_5GHZ; static final int WIFI_5GHZ_BAND_PREFERRED = BAND_2GHZ_5GHZ;
static final int WIFI_6GHZ_BAND_PREFERRED = BAND_2GHZ_5GHZ_6GHZ; static final int WIFI_6GHZ_BAND_PREFERRED = BAND_2GHZ_5GHZ_6GHZ;
@@ -477,7 +478,7 @@ public class WifiHotspotRepositoryTest {
@Test @Test
public void setSpeedType_2g5ghzTo6ghz_setConfigSecurityToWpa3() { public void setSpeedType_2g5ghzTo6ghz_setConfigSecurityToWpa3() {
mockConfig(SPEED_2GHZ_5GHZ, SECURITY_TYPE_WPA3_SAE_TRANSITION); mockConfig(SPEED_2GHZ_5GHZ, SECURITY_TYPE_WPA3_SAE_TRANSITION, WIFI_PASSWORD);
mRepository.setSpeedType(SPEED_6GHZ); mRepository.setSpeedType(SPEED_6GHZ);
@@ -497,10 +498,32 @@ public class WifiHotspotRepositoryTest {
SparseIntArray channels = mSoftApConfigCaptor.getValue().getChannels(); SparseIntArray channels = mSoftApConfigCaptor.getValue().getChannels();
assertThat(channels.get(BAND_2GHZ, CHANNEL_NOT_FOUND)).isNotEqualTo(CHANNEL_NOT_FOUND); assertThat(channels.get(BAND_2GHZ, CHANNEL_NOT_FOUND)).isNotEqualTo(CHANNEL_NOT_FOUND);
assertThat(channels.get(BAND_2GHZ_5GHZ, CHANNEL_NOT_FOUND)).isNotEqualTo(CHANNEL_NOT_FOUND); assertThat(channels.get(BAND_2GHZ_5GHZ, CHANNEL_NOT_FOUND)).isNotEqualTo(CHANNEL_NOT_FOUND);
}
@Test
public void setSpeedType_6ghzTo2g5ghzWith8CharPassphrase_changesSecurityToWpa3Transition() {
mockConfigSpeedType(SPEED_6GHZ);
mRepository.mIsDualBand = true;
mRepository.setSpeedType(SPEED_2GHZ_5GHZ);
verify(mWifiManager).setSoftApConfiguration(mSoftApConfigCaptor.capture());
assertThat(mSoftApConfigCaptor.getValue().getSecurityType()) assertThat(mSoftApConfigCaptor.getValue().getSecurityType())
.isEqualTo(SECURITY_TYPE_WPA3_SAE_TRANSITION); .isEqualTo(SECURITY_TYPE_WPA3_SAE_TRANSITION);
} }
@Test
public void setSpeedType_6ghzTo2g5ghzWithLessThan8CharPassphrase_doesNotChangeSecurity() {
mockConfig(SECURITY_TYPE_WPA3_SAE, SPEED_6GHZ, WIFI_PASSWORD_SHORT);
mRepository.mIsDualBand = true;
mRepository.setSpeedType(SPEED_2GHZ_5GHZ);
verify(mWifiManager).setSoftApConfiguration(mSoftApConfigCaptor.capture());
assertThat(mSoftApConfigCaptor.getValue().getSecurityType())
.isEqualTo(SECURITY_TYPE_WPA3_SAE);
}
@Test @Test
public void setSpeedType_2ghzTo5ghz_setConfigBandTo5ghzPreferred() { public void setSpeedType_2ghzTo5ghz_setConfigBandTo5ghzPreferred() {
mockConfigSpeedType(SPEED_2GHZ); mockConfigSpeedType(SPEED_2GHZ);
@@ -784,18 +807,18 @@ public class WifiHotspotRepositoryTest {
} }
private void mockConfigSecurityType(int securityType) { private void mockConfigSecurityType(int securityType) {
mockConfig(securityType, SPEED_2GHZ); mockConfig(securityType, SPEED_2GHZ,
(securityType == SECURITY_TYPE_OPEN) ? null : WIFI_PASSWORD);
} }
private void mockConfigSpeedType(int speedType) { private void mockConfigSpeedType(int speedType) {
mockConfig(SECURITY_TYPE_WPA3_SAE, speedType); mockConfig(SECURITY_TYPE_WPA3_SAE, speedType, WIFI_PASSWORD);
} }
private void mockConfig(int securityType, int speedType) { private void mockConfig(int securityType, int speedType, String passphrase) {
SoftApConfiguration.Builder configBuilder = new SoftApConfiguration.Builder(); SoftApConfiguration.Builder configBuilder = new SoftApConfiguration.Builder();
// Security Type // Security Type
doReturn(securityType).when(mSecurityType).getValue(); doReturn(securityType).when(mSecurityType).getValue();
String passphrase = (securityType == SECURITY_TYPE_OPEN) ? null : WIFI_PASSWORD;
configBuilder.setPassphrase(passphrase, securityType).build(); configBuilder.setPassphrase(passphrase, securityType).build();
// Speed Type // Speed Type