Merge "[Settings] Avoid from crash UI when querying data usage" into tm-dev

This commit is contained in:
Bonian Chen
2022-04-29 16:00:31 +00:00
committed by Android (Google) Code Review

View File

@@ -48,6 +48,7 @@ import android.widget.ImageView;
import android.widget.Spinner; import android.widget.Spinner;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.lifecycle.Lifecycle;
import androidx.loader.app.LoaderManager.LoaderCallbacks; import androidx.loader.app.LoaderManager.LoaderCallbacks;
import androidx.loader.content.Loader; import androidx.loader.content.Loader;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -500,6 +501,17 @@ public class DataUsageList extends DataUsageBaseFragment
+ cycle.end + "]"); + cycle.end + "]");
} }
// Avoid from updating UI after #onStop.
if (!getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.STARTED)) {
return;
}
// Avoid from updating UI when async query still on-going.
// This could happen when a request from #onMobileDataEnabledChange.
if (mCycleData == null) {
return;
}
// update chart to show selected cycle, and update detail data // update chart to show selected cycle, and update detail data
// to match updated sweep bounds. // to match updated sweep bounds.
mChart.setNetworkCycleData(mCycleData.get(position)); mChart.setNetworkCycleData(mCycleData.get(position));