PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove delayed processing of UI events in onStop

Browse Source 
Bug: 36682492
Test: manually; test tracking in b/36403635
Change-Id: Ia369cd61a6473ae2af4891cf6b923900504921c1
This commit is contained in:
Amin Shaikh
2017-03-28 11:41:32 -07:00
parent 6709b6d399
commit 5e0c60d2ac
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/com/android/settings/wifi/WifiSettings.java
View File

@@ -115,6 +115,13 @@ public class WifiSettings extends RestrictedSettingsFragment
private static final String PREF_KEY_CONFIGURE_WIFI_SETTINGS = "configure_settings"; private static final String PREF_KEY_CONFIGURE_WIFI_SETTINGS = "configure_settings";
private static final String PREF_KEY_SAVED_NETWORKS = "saved_networks"; private static final String PREF_KEY_SAVED_NETWORKS = "saved_networks";
private final Runnable mUpdateAccessPointsRunnable = () -> {
updateAccessPointPreferences();
};
private final Runnable mHideProgressBarRunnable = () -> {
setProgressBarVisible(false);
};
protected WifiManager mWifiManager; protected WifiManager mWifiManager;
private WifiManager.ActionListener mConnectListener; private WifiManager.ActionListener mConnectListener;
private WifiManager.ActionListener mSaveListener; private WifiManager.ActionListener mSaveListener;
@@ -360,8 +367,10 @@ public class WifiSettings extends RestrictedSettingsFragment
@Override @Override
public void onStop() { public void onStop() {
super.onStop();
mWifiTracker.stopTracking(); mWifiTracker.stopTracking();
getView().removeCallbacks(mUpdateAccessPointsRunnable);
getView().removeCallbacks(mHideProgressBarRunnable);
super.onStop();
} }
@Override @Override
@@ -625,9 +634,7 @@ public class WifiSettings extends RestrictedSettingsFragment
case WifiManager.WIFI_STATE_ENABLED: case WifiManager.WIFI_STATE_ENABLED:
setProgressBarVisible(true); setProgressBarVisible(true);
// Have the progress bar displayed before starting to modify APs // Have the progress bar displayed before starting to modify APs
getView().postDelayed(() -> { getView().postDelayed(mUpdateAccessPointsRunnable, 300 /* delay milliseconds */);
updateAccessPointPreferences();
}, 300 /* delay milliseconds */);
break; break;
case WifiManager.WIFI_STATE_ENABLING: case WifiManager.WIFI_STATE_ENABLING:
@@ -705,9 +712,7 @@ public class WifiSettings extends RestrictedSettingsFragment
mAccessPointsPreferenceCategory.addPreference(pref); mAccessPointsPreferenceCategory.addPreference(pref);
} else { } else {
// Continuing showing progress bar for an additional delay to overlap with animation // Continuing showing progress bar for an additional delay to overlap with animation
getView().postDelayed(() -> { getView().postDelayed(mHideProgressBarRunnable, 1700 /* delay millis */);
setProgressBarVisible(false);
}, 1700 /* delay millis */);
} }
} }