Add ring indicator for battery level
Bug: 343317785 Test: atest AdvancedBluetoothDetailsHeaderControllerTest Flag: com.android.settings.flags.enable_bluetooth_device_details_polish Change-Id: Ib657db60be8d377ea990674c4d2438ea8a6854d0
This commit is contained in:
@@ -24,3 +24,10 @@ flag {
|
|||||||
purpose: PURPOSE_BUGFIX
|
purpose: PURPOSE_BUGFIX
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
flag {
|
||||||
|
name: "enable_bluetooth_device_details_polish"
|
||||||
|
namespace: "cross_device_experiences"
|
||||||
|
description: "Gates whether to enable bluetooth device details polish"
|
||||||
|
bug: "343317785"
|
||||||
|
}
|
||||||
|
@@ -17,21 +17,43 @@
|
|||||||
|
|
||||||
<LinearLayout
|
<LinearLayout
|
||||||
xmlns:android="http://schemas.android.com/apk/res/android"
|
xmlns:android="http://schemas.android.com/apk/res/android"
|
||||||
|
xmlns:app="http://schemas.android.com/apk/res-auto"
|
||||||
android:layout_width="0dp"
|
android:layout_width="0dp"
|
||||||
android:layout_height="wrap_content"
|
android:layout_height="wrap_content"
|
||||||
android:layout_weight="1"
|
android:layout_weight="1"
|
||||||
android:focusable="true"
|
android:focusable="true"
|
||||||
android:orientation="vertical">
|
android:orientation="vertical">
|
||||||
|
|
||||||
|
<FrameLayout
|
||||||
|
android:layout_width="wrap_content"
|
||||||
|
android:layout_height="wrap_content"
|
||||||
|
android:layout_gravity="center_horizontal">
|
||||||
<ImageView
|
<ImageView
|
||||||
android:id="@+id/header_icon"
|
android:id="@+id/header_icon"
|
||||||
android:layout_width="72dp"
|
android:layout_width="72dp"
|
||||||
android:layout_height="72dp"
|
android:layout_height="72dp"
|
||||||
android:layout_gravity="center_horizontal"
|
android:layout_gravity="center"
|
||||||
android:antialias="true"
|
android:antialias="true"
|
||||||
android:background="@drawable/circle_outline"
|
android:background="@drawable/circle_outline"
|
||||||
android:padding="8dp"
|
android:padding="8dp"
|
||||||
android:scaleType="fitCenter"/>
|
android:scaleType="fitCenter" />
|
||||||
|
|
||||||
|
<com.google.android.material.progressindicator.CircularProgressIndicator
|
||||||
|
android:id="@+id/battery_ring"
|
||||||
|
android:layout_width="wrap_content"
|
||||||
|
android:layout_height="wrap_content"
|
||||||
|
android:layout_gravity="center"
|
||||||
|
android:indeterminate="false"
|
||||||
|
app:trackColor="@android:color/transparent"
|
||||||
|
app:indicatorColor="@color/bluetooth_battery_ring_indicator_color"
|
||||||
|
app:trackThickness="4dp"
|
||||||
|
app:indicatorSize="76dp"
|
||||||
|
app:indicatorInset="0dp"
|
||||||
|
app:trackCornerRadius="2dp"
|
||||||
|
android:max="100"
|
||||||
|
android:visibility="gone" />
|
||||||
|
|
||||||
|
</FrameLayout>
|
||||||
|
|
||||||
<TextView
|
<TextView
|
||||||
android:id="@+id/header_title"
|
android:id="@+id/header_title"
|
||||||
|
@@ -218,4 +218,7 @@
|
|||||||
|
|
||||||
<!-- Switch bar disabled state color-->
|
<!-- Switch bar disabled state color-->
|
||||||
<color name="switch_bar_state_disabled_color">#1F1F1F1F</color>
|
<color name="switch_bar_state_disabled_color">#1F1F1F1F</color>
|
||||||
|
|
||||||
|
<!-- Battery ring indicator color in bluetooth device details -->
|
||||||
|
<color name="bluetooth_battery_ring_indicator_color">#9ED582</color>
|
||||||
</resources>
|
</resources>
|
||||||
|
@@ -39,6 +39,7 @@ import android.view.View;
|
|||||||
import android.view.ViewGroup;
|
import android.view.ViewGroup;
|
||||||
import android.widget.ImageView;
|
import android.widget.ImageView;
|
||||||
import android.widget.LinearLayout;
|
import android.widget.LinearLayout;
|
||||||
|
import android.widget.ProgressBar;
|
||||||
import android.widget.TextView;
|
import android.widget.TextView;
|
||||||
|
|
||||||
import androidx.annotation.VisibleForTesting;
|
import androidx.annotation.VisibleForTesting;
|
||||||
@@ -46,6 +47,7 @@ import androidx.preference.PreferenceScreen;
|
|||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
import com.android.settings.core.BasePreferenceController;
|
import com.android.settings.core.BasePreferenceController;
|
||||||
|
import com.android.settings.flags.Flags;
|
||||||
import com.android.settings.fuelgauge.BatteryMeterView;
|
import com.android.settings.fuelgauge.BatteryMeterView;
|
||||||
import com.android.settingslib.bluetooth.BluetoothUtils;
|
import com.android.settingslib.bluetooth.BluetoothUtils;
|
||||||
import com.android.settingslib.bluetooth.CachedBluetoothDevice;
|
import com.android.settingslib.bluetooth.CachedBluetoothDevice;
|
||||||
@@ -456,18 +458,24 @@ public class AdvancedBluetoothDetailsHeaderController extends BasePreferenceCont
|
|||||||
com.android.settings.Utils.formatPercentage(batteryLevel));
|
com.android.settings.Utils.formatPercentage(batteryLevel));
|
||||||
batterySummaryView.setVisibility(View.VISIBLE);
|
batterySummaryView.setVisibility(View.VISIBLE);
|
||||||
showBatteryIcon(linearLayout, batteryLevel, lowBatteryLevel, charging);
|
showBatteryIcon(linearLayout, batteryLevel, lowBatteryLevel, charging);
|
||||||
|
showBatteryRing(linearLayout, batteryLevel);
|
||||||
} else {
|
} else {
|
||||||
if (deviceId == MAIN_DEVICE_ID) {
|
if (deviceId == MAIN_DEVICE_ID) {
|
||||||
linearLayout.setVisibility(View.VISIBLE);
|
linearLayout.setVisibility(View.VISIBLE);
|
||||||
linearLayout.findViewById(R.id.bt_battery_icon).setVisibility(View.GONE);
|
linearLayout.findViewById(R.id.bt_battery_icon).setVisibility(View.GONE);
|
||||||
|
|
||||||
int level = preloadedNativeBatteryLevel.get();
|
int level = preloadedNativeBatteryLevel.get();
|
||||||
if (level != BluetoothDevice.BATTERY_LEVEL_UNKNOWN
|
if (level != BluetoothDevice.BATTERY_LEVEL_UNKNOWN
|
||||||
&& level != BluetoothDevice.BATTERY_LEVEL_BLUETOOTH_OFF) {
|
&& level != BluetoothDevice.BATTERY_LEVEL_BLUETOOTH_OFF) {
|
||||||
batterySummaryView.setText(
|
batterySummaryView.setText(
|
||||||
com.android.settings.Utils.formatPercentage(level));
|
com.android.settings.Utils.formatPercentage(level));
|
||||||
batterySummaryView.setVisibility(View.VISIBLE);
|
batterySummaryView.setVisibility(View.VISIBLE);
|
||||||
|
showBatteryRing(linearLayout, level);
|
||||||
} else {
|
} else {
|
||||||
batterySummaryView.setVisibility(View.GONE);
|
batterySummaryView.setVisibility(View.GONE);
|
||||||
|
if (Flags.enableBluetoothDeviceDetailsPolish()) {
|
||||||
|
linearLayout.findViewById(R.id.battery_ring).setVisibility(View.GONE);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
// Hide it if it doesn't have battery information
|
// Hide it if it doesn't have battery information
|
||||||
@@ -481,6 +489,7 @@ public class AdvancedBluetoothDetailsHeaderController extends BasePreferenceCont
|
|||||||
com.android.settings.Utils.formatPercentage(batteryLevel));
|
com.android.settings.Utils.formatPercentage(batteryLevel));
|
||||||
batterySummaryView.setVisibility(View.VISIBLE);
|
batterySummaryView.setVisibility(View.VISIBLE);
|
||||||
showBatteryIcon(linearLayout, batteryLevel, lowBatteryLevel, charging);
|
showBatteryIcon(linearLayout, batteryLevel, lowBatteryLevel, charging);
|
||||||
|
showBatteryRing(linearLayout, batteryLevel);
|
||||||
} else {
|
} else {
|
||||||
batterySummaryView.setVisibility(View.GONE);
|
batterySummaryView.setVisibility(View.GONE);
|
||||||
}
|
}
|
||||||
@@ -610,6 +619,14 @@ public class AdvancedBluetoothDetailsHeaderController extends BasePreferenceCont
|
|||||||
imageView.setVisibility(View.VISIBLE);
|
imageView.setVisibility(View.VISIBLE);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private void showBatteryRing(LinearLayout linearLayout, int level) {
|
||||||
|
if (Flags.enableBluetoothDeviceDetailsPolish()) {
|
||||||
|
ProgressBar batteryProgress = linearLayout.findViewById(R.id.battery_ring);
|
||||||
|
batteryProgress.setProgress(level);
|
||||||
|
batteryProgress.setVisibility(View.VISIBLE);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private void updateDisconnectLayout() {
|
private void updateDisconnectLayout() {
|
||||||
mLayoutPreference.findViewById(R.id.layout_left).setVisibility(View.GONE);
|
mLayoutPreference.findViewById(R.id.layout_left).setVisibility(View.GONE);
|
||||||
mLayoutPreference.findViewById(R.id.layout_right).setVisibility(View.GONE);
|
mLayoutPreference.findViewById(R.id.layout_right).setVisibility(View.GONE);
|
||||||
@@ -620,6 +637,9 @@ public class AdvancedBluetoothDetailsHeaderController extends BasePreferenceCont
|
|||||||
linearLayout.findViewById(R.id.header_title).setVisibility(View.GONE);
|
linearLayout.findViewById(R.id.header_title).setVisibility(View.GONE);
|
||||||
linearLayout.findViewById(R.id.bt_battery_summary).setVisibility(View.GONE);
|
linearLayout.findViewById(R.id.bt_battery_summary).setVisibility(View.GONE);
|
||||||
linearLayout.findViewById(R.id.bt_battery_icon).setVisibility(View.GONE);
|
linearLayout.findViewById(R.id.bt_battery_icon).setVisibility(View.GONE);
|
||||||
|
if (Flags.enableBluetoothDeviceDetailsPolish()) {
|
||||||
|
linearLayout.findViewById(R.id.battery_ring).setVisibility(View.GONE);
|
||||||
|
}
|
||||||
|
|
||||||
// Only show bluetooth icon
|
// Only show bluetooth icon
|
||||||
final BluetoothDevice bluetoothDevice = mCachedDevice.getDevice();
|
final BluetoothDevice bluetoothDevice = mCachedDevice.getDevice();
|
||||||
|
@@ -28,16 +28,20 @@ import android.bluetooth.BluetoothDevice;
|
|||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.graphics.Bitmap;
|
import android.graphics.Bitmap;
|
||||||
import android.graphics.drawable.Drawable;
|
import android.graphics.drawable.Drawable;
|
||||||
|
import android.platform.test.flag.junit.SetFlagsRule;
|
||||||
import android.provider.DeviceConfig;
|
import android.provider.DeviceConfig;
|
||||||
import android.view.LayoutInflater;
|
import android.view.LayoutInflater;
|
||||||
import android.view.View;
|
import android.view.View;
|
||||||
import android.widget.ImageView;
|
import android.widget.ImageView;
|
||||||
import android.widget.LinearLayout;
|
import android.widget.LinearLayout;
|
||||||
|
import android.widget.ProgressBar;
|
||||||
import android.widget.TextView;
|
import android.widget.TextView;
|
||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.SettingsActivity;
|
||||||
import com.android.settings.core.BasePreferenceController;
|
import com.android.settings.core.BasePreferenceController;
|
||||||
import com.android.settings.core.SettingsUIDeviceConfig;
|
import com.android.settings.core.SettingsUIDeviceConfig;
|
||||||
|
import com.android.settings.flags.Flags;
|
||||||
import com.android.settings.fuelgauge.BatteryMeterView;
|
import com.android.settings.fuelgauge.BatteryMeterView;
|
||||||
import com.android.settings.testutils.shadow.ShadowDeviceConfig;
|
import com.android.settings.testutils.shadow.ShadowDeviceConfig;
|
||||||
import com.android.settings.testutils.shadow.ShadowEntityHeaderController;
|
import com.android.settings.testutils.shadow.ShadowEntityHeaderController;
|
||||||
@@ -48,12 +52,13 @@ import com.android.settingslib.widget.LayoutPreference;
|
|||||||
|
|
||||||
import org.junit.Before;
|
import org.junit.Before;
|
||||||
import org.junit.Ignore;
|
import org.junit.Ignore;
|
||||||
|
import org.junit.Rule;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
import org.mockito.Mock;
|
import org.mockito.Mock;
|
||||||
import org.mockito.MockitoAnnotations;
|
import org.mockito.MockitoAnnotations;
|
||||||
|
import org.robolectric.Robolectric;
|
||||||
import org.robolectric.RobolectricTestRunner;
|
import org.robolectric.RobolectricTestRunner;
|
||||||
import org.robolectric.RuntimeEnvironment;
|
|
||||||
import org.robolectric.annotation.Config;
|
import org.robolectric.annotation.Config;
|
||||||
|
|
||||||
import java.util.HashSet;
|
import java.util.HashSet;
|
||||||
@@ -62,6 +67,8 @@ import java.util.Set;
|
|||||||
@RunWith(RobolectricTestRunner.class)
|
@RunWith(RobolectricTestRunner.class)
|
||||||
@Config(shadows = {ShadowEntityHeaderController.class, ShadowDeviceConfig.class})
|
@Config(shadows = {ShadowEntityHeaderController.class, ShadowDeviceConfig.class})
|
||||||
public class AdvancedBluetoothDetailsHeaderControllerTest {
|
public class AdvancedBluetoothDetailsHeaderControllerTest {
|
||||||
|
@Rule public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();
|
||||||
|
|
||||||
private static final int BATTERY_LEVEL_MAIN = 30;
|
private static final int BATTERY_LEVEL_MAIN = 30;
|
||||||
private static final int BATTERY_LEVEL_LEFT = 25;
|
private static final int BATTERY_LEVEL_LEFT = 25;
|
||||||
private static final int BATTERY_LEVEL_RIGHT = 45;
|
private static final int BATTERY_LEVEL_RIGHT = 45;
|
||||||
@@ -93,7 +100,7 @@ public class AdvancedBluetoothDetailsHeaderControllerTest {
|
|||||||
public void setUp() {
|
public void setUp() {
|
||||||
MockitoAnnotations.initMocks(this);
|
MockitoAnnotations.initMocks(this);
|
||||||
|
|
||||||
mContext = RuntimeEnvironment.application;
|
mContext = Robolectric.buildActivity(SettingsActivity.class).get();
|
||||||
mController = new AdvancedBluetoothDetailsHeaderController(mContext, "pref_Key");
|
mController = new AdvancedBluetoothDetailsHeaderController(mContext, "pref_Key");
|
||||||
when(mCachedDevice.getDevice()).thenReturn(mBluetoothDevice);
|
when(mCachedDevice.getDevice()).thenReturn(mBluetoothDevice);
|
||||||
mController.init(mCachedDevice);
|
mController.init(mCachedDevice);
|
||||||
@@ -272,6 +279,7 @@ public class AdvancedBluetoothDetailsHeaderControllerTest {
|
|||||||
View.GONE);
|
View.GONE);
|
||||||
assertThat(layout.findViewById(R.id.bt_battery_icon).getVisibility()).isEqualTo(View.GONE);
|
assertThat(layout.findViewById(R.id.bt_battery_icon).getVisibility()).isEqualTo(View.GONE);
|
||||||
assertThat(layout.findViewById(R.id.header_icon).getVisibility()).isEqualTo(View.VISIBLE);
|
assertThat(layout.findViewById(R.id.header_icon).getVisibility()).isEqualTo(View.VISIBLE);
|
||||||
|
assertThat(layout.findViewById(R.id.battery_ring).getVisibility()).isEqualTo(View.GONE);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Ignore
|
@Ignore
|
||||||
@@ -546,6 +554,10 @@ public class AdvancedBluetoothDetailsHeaderControllerTest {
|
|||||||
final TextView textView = linearLayout.findViewById(R.id.bt_battery_summary);
|
final TextView textView = linearLayout.findViewById(R.id.bt_battery_summary);
|
||||||
assertThat(textView.getText().toString()).isEqualTo(
|
assertThat(textView.getText().toString()).isEqualTo(
|
||||||
com.android.settings.Utils.formatPercentage(batteryLevel));
|
com.android.settings.Utils.formatPercentage(batteryLevel));
|
||||||
|
if (Flags.enableBluetoothDeviceDetailsPolish()) {
|
||||||
|
final ProgressBar bar = linearLayout.findViewById(R.id.battery_ring);
|
||||||
|
assertThat(bar.getProgress()).isEqualTo(batteryLevel);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private void assertBatteryIcon(LinearLayout linearLayout, int resId) {
|
private void assertBatteryIcon(LinearLayout linearLayout, int resId) {
|
||||||
|
@@ -33,9 +33,9 @@ import android.widget.TextView;
|
|||||||
|
|
||||||
import androidx.preference.PreferenceManager;
|
import androidx.preference.PreferenceManager;
|
||||||
import androidx.preference.PreferenceScreen;
|
import androidx.preference.PreferenceScreen;
|
||||||
import androidx.test.core.app.ApplicationProvider;
|
|
||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.SettingsActivity;
|
||||||
import com.android.settingslib.widget.LayoutPreference;
|
import com.android.settingslib.widget.LayoutPreference;
|
||||||
|
|
||||||
import org.junit.Before;
|
import org.junit.Before;
|
||||||
@@ -43,6 +43,7 @@ import org.junit.Test;
|
|||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
import org.mockito.Mock;
|
import org.mockito.Mock;
|
||||||
import org.mockito.MockitoAnnotations;
|
import org.mockito.MockitoAnnotations;
|
||||||
|
import org.robolectric.Robolectric;
|
||||||
import org.robolectric.RobolectricTestRunner;
|
import org.robolectric.RobolectricTestRunner;
|
||||||
|
|
||||||
@RunWith(RobolectricTestRunner.class)
|
@RunWith(RobolectricTestRunner.class)
|
||||||
@@ -72,7 +73,7 @@ public class StylusUsiHeaderControllerTest {
|
|||||||
when(mBatteryState.getCapacity()).thenReturn(1f);
|
when(mBatteryState.getCapacity()).thenReturn(1f);
|
||||||
when(mBatteryState.isPresent()).thenReturn(true);
|
when(mBatteryState.isPresent()).thenReturn(true);
|
||||||
|
|
||||||
mContext = spy(ApplicationProvider.getApplicationContext());
|
mContext = spy(Robolectric.buildActivity(SettingsActivity.class).get());
|
||||||
when(mContext.getSystemService(InputManager.class)).thenReturn(mInputManager);
|
when(mContext.getSystemService(InputManager.class)).thenReturn(mInputManager);
|
||||||
mController = new StylusUsiHeaderController(mContext, mInputDevice);
|
mController = new StylusUsiHeaderController(mContext, mInputDevice);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user