From 5d80fd29665214bb692a85af0c9bae1054fad2f7 Mon Sep 17 00:00:00 2001
From: Fan Zhang <zhfan@google.com>
Date: Wed, 18 Oct 2017 11:47:01 -0700
Subject: [PATCH] Fix a monkey crash: guard against position -1.

When handling onClick in ManageApplications, skip getAppEntry if
position is -1.

Change-Id: I565c42b2c9f742445e49fd4c2e7db539d0f6f8ad
Fixes: 67940121
Test: manual
---
 .../applications/manageapplications/ManageApplications.java   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/com/android/settings/applications/manageapplications/ManageApplications.java b/src/com/android/settings/applications/manageapplications/ManageApplications.java
index 6b21128c691..3caa8ab43c9 100644
--- a/src/com/android/settings/applications/manageapplications/ManageApplications.java
+++ b/src/com/android/settings/applications/manageapplications/ManageApplications.java
@@ -647,6 +647,10 @@ public class ManageApplications extends InstrumentedPreferenceFragment
         }
         final int position = mRecyclerView.getChildAdapterPosition(view);
 
+        if (position == RecyclerView.NO_POSITION) {
+            Log.w(TAG, "Cannot find position for child, skipping onClick handling");
+            return;
+        }
         if (mApplications.getApplicationCount() > position) {
             ApplicationsState.AppEntry entry = mApplications.getAppEntry(position);
             mCurrentPkgName = entry.info.packageName;