diff --git a/res/values/config.xml b/res/values/config.xml index 4ba73cc8a0e..097350b0b81 100755 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -41,9 +41,6 @@ false - - false - false diff --git a/res/values/strings.xml b/res/values/strings.xml index d1920a616b1..a144d4d4737 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -8275,12 +8275,6 @@ To apply connectivity monitor change, reboot device - - Camera HAL HDR+ - - - To apply Camera HAL HDR+ change, reboot device - Camera Laser Sensor diff --git a/res/xml/development_prefs.xml b/res/xml/development_prefs.xml index c8c57a5c3a6..669f4fb93c6 100644 --- a/res/xml/development_prefs.xml +++ b/res/xml/development_prefs.xml @@ -172,10 +172,6 @@ android:key="camera_laser_sensor_switch" android:title="@string/camera_laser_sensor_switch" /> - - - false false false false diff --git a/tests/robotests/res/values/config.xml b/tests/robotests/res/values/config.xml index 0afbe2925c6..9e2d911b023 100644 --- a/tests/robotests/res/values/config.xml +++ b/tests/robotests/res/values/config.xml @@ -19,6 +19,5 @@ true true true - true true \ No newline at end of file diff --git a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java deleted file mode 100644 index 48833e4f0b4..00000000000 --- a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java +++ /dev/null @@ -1,150 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings.development; - -import android.content.Context; -import android.os.SystemProperties; -import android.support.v14.preference.SwitchPreference; -import android.support.v7.preference.PreferenceScreen; - -import com.android.settings.R; -import com.android.settings.testutils.SettingsRobolectricTestRunner; -import com.android.settings.TestConfig; -import com.android.settings.testutils.shadow.SettingsShadowSystemProperties; - -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Answers; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; -import org.robolectric.annotation.Config; -import org.robolectric.RuntimeEnvironment; - -import static com.google.common.truth.Truth.assertThat; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; - -/** - * deprecated in favor of {@link CameraHalHdrPlusPreferenceControllerV2} - */ -@Deprecated -@RunWith(SettingsRobolectricTestRunner.class) -@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION, - shadows = {SettingsShadowSystemProperties.class}) -public class CameraHalHdrplusPreferenceControllerTest { - - @Mock(answer = Answers.RETURNS_DEEP_STUBS) - private Context mContext; - @Mock - private PreferenceScreen mScreen; - @Mock - private SwitchPreference mPreference; - - static final String USERDEBUG_BUILD = "userdebug"; - - private CameraHalHdrplusPreferenceController mController; - - @Before - public void setUp() { - MockitoAnnotations.initMocks(this); - mController = new CameraHalHdrplusPreferenceController(mContext); - when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); - when(mPreference.getKey()).thenReturn(mController.getPreferenceKey()); - } - - @After - public void tearDown() { - SettingsShadowSystemProperties.clear(); - } - - @Test - public void isAvailable_withConfigNoShow_shouldReturnFalse() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(false); - assertThat(mController.isAvailable()).isFalse(); - } - - @Test - public void displayPreference_cameraHalHdrplusEnabled_shouldCheckedPreference() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.ENABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.BUILD_TYPE, USERDEBUG_BUILD); - - mController.displayPreference(mScreen); - - verify(mPreference).setChecked(true); - } - - @Test - public void displayPreference_cameraHalHdrplusEnabled_shouldUncheckedPreference() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.BUILD_TYPE, USERDEBUG_BUILD); - - mController.displayPreference(mScreen); - - verify(mPreference).setChecked(false); - } - - @Test - public void handlePreferenceTreeClick_preferenceChecked_shouldEnableCameraHalHdrplus() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - when(mPreference.isChecked()).thenReturn(true); - - when(mContext.getResources().getString(R.string.camera_hal_hdrplus_toast)).thenReturn( - RuntimeEnvironment.application.getString(R.string.camera_hal_hdrplus_toast)); - - mController.handlePreferenceTreeClick(mPreference); - - assertThat(CameraHalHdrplusPreferenceController.ENABLED.equals( - SystemProperties.get( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED))).isTrue(); - } - - @Test - public void handlePreferenceTreeClick_preferenceUnchecked_shouldDisableCameraHalHdrplus() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - when(mPreference.isChecked()).thenReturn(false); - - when(mContext.getResources().getString(R.string.camera_hal_hdrplus_toast)).thenReturn( - RuntimeEnvironment.application.getString(R.string.camera_hal_hdrplus_toast)); - - mController.handlePreferenceTreeClick(mPreference); - - assertThat(CameraHalHdrplusPreferenceController.DISABLED.equals( - SystemProperties.get( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED))).isTrue(); - } -} diff --git a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerV2Test.java b/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerV2Test.java deleted file mode 100644 index e0e137c3b19..00000000000 --- a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerV2Test.java +++ /dev/null @@ -1,145 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings.development; - -import static com.google.common.truth.Truth.assertThat; - -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; - -import android.content.Context; -import android.os.SystemProperties; -import android.support.v14.preference.SwitchPreference; -import android.support.v7.preference.PreferenceScreen; - -import com.android.settings.TestConfig; -import com.android.settings.testutils.SettingsRobolectricTestRunner; -import com.android.settings.testutils.shadow.SettingsShadowSystemProperties; - -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; -import org.robolectric.RuntimeEnvironment; -import org.robolectric.annotation.Config; - -@RunWith(SettingsRobolectricTestRunner.class) -@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION, - shadows = {SettingsShadowSystemProperties.class}) -public class CameraHalHdrplusPreferenceControllerV2Test { - - @Mock - private PreferenceScreen mScreen; - @Mock - private SwitchPreference mPreference; - - private Context mContext; - private CameraHalHdrplusPreferenceControllerV2 mController; - - static final String USERDEBUG_BUILD = "userdebug"; - - @Before - public void setUp() { - MockitoAnnotations.initMocks(this); - mContext = RuntimeEnvironment.application; - mController = new CameraHalHdrplusPreferenceControllerV2(mContext); - when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); - when(mPreference.getKey()).thenReturn(mController.getPreferenceKey()); - mController.displayPreference(mScreen); - } - - @After - public void tearDown() { - SettingsShadowSystemProperties.clear(); - } - - @Test - @Config(qualifiers = "mcc999") - public void isAvailable_withConfigNoShowAndUserDebugBuild_shouldReturnFalse() { - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceControllerV2.BUILD_TYPE, USERDEBUG_BUILD); - - assertThat(mController.isAvailable()).isFalse(); - } - - @Test - public void updateState_cameraHalHdrplusEnabled_shouldCheckedPreference() { - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceControllerV2.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceControllerV2.ENABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceControllerV2.BUILD_TYPE, USERDEBUG_BUILD); - - mController.updateState(mPreference); - - verify(mPreference).setChecked(true); - } - - @Test - public void updateState_cameraHalHdrplusEnabled_shouldUncheckedPreference() { - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceControllerV2.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceControllerV2.DISABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceControllerV2.BUILD_TYPE, USERDEBUG_BUILD); - - mController.updateState(mPreference); - - verify(mPreference).setChecked(false); - } - - @Test - public void onPreferenceChange_preferenceChecked_shouldEnableCameraHalHdrplus() { - mController.onPreferenceChange(mPreference, true /* new value */); - - assertThat(CameraHalHdrplusPreferenceControllerV2.ENABLED).isEqualTo( - SystemProperties.get( - CameraHalHdrplusPreferenceControllerV2.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceControllerV2.DISABLED)); - } - - @Test - public void handlePreferenceTreeClick_preferenceUnchecked_shouldDisableCameraHalHdrplus() { - mController.onPreferenceChange(mPreference, false /* new value */); - - assertThat(CameraHalHdrplusPreferenceControllerV2.DISABLED).isEqualTo( - SystemProperties.get( - CameraHalHdrplusPreferenceControllerV2.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceControllerV2.DISABLED)); - } - - @Test - public void onDeveloperOptionsSwitchEnabled_shouldEnablePreference() { - mController.onDeveloperOptionsSwitchEnabled(); - - verify(mPreference).setEnabled(true); - } - - @Test - public void onDeveloperOptionsSwitchDisabled_shouldDisablePreference() { - mController.onDeveloperOptionsSwitchDisabled(); - - verify(mPreference).setEnabled(false); - verify(mPreference).setChecked(false); - assertThat(CameraHalHdrplusPreferenceControllerV2.DISABLED).isEqualTo( - SystemProperties.get( - CameraHalHdrplusPreferenceControllerV2.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceControllerV2.DISABLED)); - } -}