From 22ed240aab5df0d1b7daadef77f38067e0e7b45e Mon Sep 17 00:00:00 2001 From: Peter_Liang Date: Tue, 16 Jun 2020 17:28:20 +0800 Subject: [PATCH] Fix the dark theme obscures the center marker of audio balance slider. Root Cause: The color of center marker is wrong. Next: The color of center marker is white when dark theme is enabled; Otherwise, it's black. Bug: 159028208 Test: manual test & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarPreferenceTest & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest Change-Id: Id2d548778d1275709448f4c009a8469216950d8c Merged-In: Id2d548778d1275709448f4c009a8469216950d8c (cherry picked from commit 34a873884dfa5e213d7096e52dc16929581f191b) --- src/com/android/settings/accessibility/BalanceSeekBar.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/accessibility/BalanceSeekBar.java b/src/com/android/settings/accessibility/BalanceSeekBar.java index b108e18d2f0..ecc226bd67d 100644 --- a/src/com/android/settings/accessibility/BalanceSeekBar.java +++ b/src/com/android/settings/accessibility/BalanceSeekBar.java @@ -16,6 +16,8 @@ package com.android.settings.accessibility; +import static com.android.settings.Utils.isNightMode; + import android.content.Context; import android.content.res.ColorStateList; import android.content.res.Resources; @@ -113,8 +115,7 @@ public class BalanceSeekBar extends SeekBar { res.getDimensionPixelSize(R.dimen.balance_seekbar_center_marker_width), res.getDimensionPixelSize(R.dimen.balance_seekbar_center_marker_height)); mCenterMarkerPaint = new Paint(); - // TODO use a more suitable colour? - mCenterMarkerPaint.setColor(Color.BLACK); + mCenterMarkerPaint.setColor(isNightMode(context) ? Color.WHITE : Color.BLACK); mCenterMarkerPaint.setStyle(Paint.Style.FILL); // Remove the progress colour setProgressTintList(ColorStateList.valueOf(Color.TRANSPARENT));