From 49d314f8c35e1a6d26c50014cb6faeb817d27b9b Mon Sep 17 00:00:00 2001 From: Yuchen Chang Date: Wed, 7 Mar 2018 14:44:33 +0800 Subject: [PATCH] [Settings] Request focus in Add network dialog Request focus for SSID EditText to show IME when user choose add network in wifi screen. Bug: 72882629 Test: RunSettingsRobotests & Manual test Change-Id: Iaf4db085c3d310a7f524217a90dc1fb7573d6814 --- src/com/android/settings/wifi/WifiConfigController.java | 1 + .../android/settings/wifi/WifiConfigControllerTest.java | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/src/com/android/settings/wifi/WifiConfigController.java b/src/com/android/settings/wifi/WifiConfigController.java index d7b42996308..1e326b84ece 100644 --- a/src/com/android/settings/wifi/WifiConfigController.java +++ b/src/com/android/settings/wifi/WifiConfigController.java @@ -215,6 +215,7 @@ public class WifiConfigController implements TextWatcher, mSsidView = (TextView) mView.findViewById(R.id.ssid); mSsidView.addTextChangedListener(this); + mSsidView.requestFocus(); mSecuritySpinner = ((Spinner) mView.findViewById(R.id.security)); mSecuritySpinner.setOnItemSelectedListener(this); mView.findViewById(R.id.type).setVisibility(View.VISIBLE); diff --git a/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java b/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java index bbe104c1641..e5c71449c92 100644 --- a/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java @@ -210,6 +210,15 @@ public class WifiConfigControllerTest { assertThat(mView.findViewById(R.id.eap).getVisibility()).isEqualTo(View.GONE); } + @Test + public void ssidGetFocus_addNewNetwork_shouldReturnTrue() { + mController = new TestWifiConfigController(mConfigUiBase, mView, null /* accessPoint */, + WifiConfigUiBase.MODE_CONNECT); + final TextView ssid = mView.findViewById(R.id.ssid); + // Verify ssid text get focus when add new network (accesspoint is null) + assertThat(ssid.isFocused()).isTrue(); + } + public class TestWifiConfigController extends WifiConfigController { private TestWifiConfigController(