From 5cb18299a9ab5946b59c7162212f2de27f9552a2 Mon Sep 17 00:00:00 2001 From: Sunny Shao Date: Wed, 7 Aug 2019 20:35:24 +0800 Subject: [PATCH] Use FooterPreference in FingerprintSettings page Use the new FooterPreference and removed the old FooterPreferenceMixin from the FingerprintSettings page. Fixes: 139050306 Test: manual test Change-Id: Ia4a2dda57512e30ee8628ad18d9c4263b88d13fc --- .../fingerprint/FingerprintSettings.java | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/biometrics/fingerprint/FingerprintSettings.java b/src/com/android/settings/biometrics/fingerprint/FingerprintSettings.java index 3fbcfd4be96..c90a0ded752 100644 --- a/src/com/android/settings/biometrics/fingerprint/FingerprintSettings.java +++ b/src/com/android/settings/biometrics/fingerprint/FingerprintSettings.java @@ -132,6 +132,7 @@ public class FingerprintSettings extends SubSettings { private boolean mLaunchedConfirm; private Drawable mHighlightDrawable; private int mUserId; + private CharSequence mFooterTitle; private static final String TAG_AUTHENTICATE_SIDECAR = "authenticate_sidecar"; private static final String TAG_REMOVAL_SIDECAR = "removal_sidecar"; @@ -323,7 +324,6 @@ public class FingerprintSettings extends SubSettings { launchChooseOrConfirmLock(); } - final FooterPreference pref = mFooterPreferenceMixin.createFooterPreference(); final EnforcedAdmin admin = RestrictedLockUtilsInternal.checkIfKeyguardFeaturesDisabled( activity, DevicePolicyManager.KEYGUARD_DISABLE_FINGERPRINT, mUserId); final AnnotationSpan.LinkInfo adminLinkInfo = new AnnotationSpan.LinkInfo( @@ -334,11 +334,11 @@ public class FingerprintSettings extends SubSettings { activity, getString(getHelpResource()), activity.getClass().getName()); final AnnotationSpan.LinkInfo linkInfo = new AnnotationSpan.LinkInfo( activity, ANNOTATION_URL, helpIntent); - pref.setTitle(AnnotationSpan.linkify(getText(admin != null + mFooterTitle = AnnotationSpan.linkify(getText(admin != null ? R.string .security_settings_fingerprint_enroll_disclaimer_lockscreen_disabled : R.string.security_settings_fingerprint_enroll_disclaimer), - linkInfo, adminLinkInfo)); + linkInfo, adminLinkInfo); } protected void removeFingerprintPreference(int fingerprintId) { @@ -400,6 +400,7 @@ public class FingerprintSettings extends SubSettings { root.addPreference(addPreference); addPreference.setOnPreferenceChangeListener(this); updateAddPreference(); + createFooterPreference(root); } private void updateAddPreference() { @@ -419,6 +420,18 @@ public class FingerprintSettings extends SubSettings { addPreference.setEnabled(!tooMany && !removalInProgress); } + private void createFooterPreference(PreferenceGroup root) { + final Context context = getActivity(); + if (context == null) { + return; + } + + final FooterPreference footerPreference = new FooterPreference(context); + footerPreference.setTitle(mFooterTitle); + footerPreference.setSelectable(false); + root.addPreference(footerPreference); + } + private static String genKey(int id) { return KEY_FINGERPRINT_ITEM_PREFIX + "_" + id; }