Misc logging improvements
- Log ACTION_SEARCH_RESULTS whenever a search query is performed. eg, type "qu" will result 2 such logging events. - Remove historam logging to search result click count (already logged as ACTION_CLICK_SETTINGS_SEARCH_RESULT) Change-Id: Ia207b34702e0f24a7885e47d093f6cce1314ebc4 Fixes: 67743512 Fixes: 64939544 Test: robotests
This commit is contained in:
@@ -43,6 +43,7 @@ import com.android.internal.logging.nano.MetricsProto;
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.SettingsActivity;
|
||||
import com.android.settings.TestConfig;
|
||||
import com.android.settings.core.instrumentation.VisibilityLoggerMixin;
|
||||
import com.android.settings.testutils.DatabaseTestUtils;
|
||||
import com.android.settings.testutils.FakeFeatureFactory;
|
||||
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
||||
@@ -207,8 +208,6 @@ public class SearchFragmentTest {
|
||||
verify(mFeatureFactory.metricsFeatureProvider, never()).action(
|
||||
any(Context.class),
|
||||
eq(MetricsProto.MetricsEvent.ACTION_LEAVE_SEARCH_RESULT_WITHOUT_QUERY));
|
||||
verify(mFeatureFactory.metricsFeatureProvider).histogram(
|
||||
any(Context.class), eq(SearchFragment.RESULT_CLICK_COUNT), eq(0));
|
||||
verify(mFeatureFactory.searchFeatureProvider)
|
||||
.getDatabaseSearchLoader(any(Context.class), anyString());
|
||||
verify(mFeatureFactory.searchFeatureProvider)
|
||||
@@ -231,6 +230,10 @@ public class SearchFragmentTest {
|
||||
any(Context.class),
|
||||
anyInt(),
|
||||
eq(MetricsProto.MetricsEvent.SETTINGS_SEARCH_NO_RESULT));
|
||||
verify(mFeatureFactory.metricsFeatureProvider).action(
|
||||
any(VisibilityLoggerMixin.class),
|
||||
eq(MetricsProto.MetricsEvent.ACTION_SEARCH_RESULTS),
|
||||
eq(1));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
Reference in New Issue
Block a user