PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix a crash when launching app detail for bad package name" am: ada1a39ffb

Browse Source 
am: 2e2e1e243d

Change-Id: I3614f70f71c0e0eb064331175cb51fa30ed5a5b7
This commit is contained in:
Fan Zhang
2018-09-11 18:49:12 -07:00
committed by android-build-merger
parent 8a25b25da1 2e2e1e243d
commit 59cd5abb96
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/robotests/src/com/android/settings/applications/appinfo/AppInfoDashboardFragmentTest.java
View File

@@ -167,7 +167,7 @@ public final class AppInfoDashboardFragmentTest {
}
@Test
public void launchFragment_hasNoPackageInfo_shouldFinish() {
public void ensurePackageInfoAvailable_hasNoPackageInfo_shouldFinish() {
ReflectionHelpers.setField(mFragment, "mPackageInfo", null);
assertThat(mFragment.ensurePackageInfoAvailable(mActivity)).isFalse();
@@ -175,7 +175,7 @@ public final class AppInfoDashboardFragmentTest {
}
@Test
public void launchFragment_hasPackageInfo_shouldReturnTrue() {
public void ensurePackageInfoAvailable_hasPackageInfo_shouldReturnTrue() {
final PackageInfo packageInfo = mock(PackageInfo.class);
ReflectionHelpers.setField(mFragment, "mPackageInfo", packageInfo);
@@ -183,6 +183,16 @@ public final class AppInfoDashboardFragmentTest {
verify(mActivity, never()).finishAndRemoveTask();
}
@Test
public void createPreference_hasNoPackageInfo_shouldSkip() {
ReflectionHelpers.setField(mFragment, "mPackageInfo", null);
mFragment.onCreatePreferences(new Bundle(), "root_key");
verify(mActivity).finishAndRemoveTask();
verify(mFragment, never()).getPreferenceScreen();
}
@Test
public void packageSizeChange_isOtherPackage_shouldNotRefreshUi() {
ReflectionHelpers.setField(mFragment, "mPackageName", PACKAGE_NAME);