[Settings] Use Settings flag to keep consistency
Bug: 401438916 Test: manual Flag: EXEMPT refactor Change-Id: Ie7d1bf50c119eb5b5bcea55508c6a8a842bc60ee
This commit is contained in:
@@ -28,10 +28,3 @@ flag {
|
|||||||
description: "Feature flag for regional preferences APIs"
|
description: "Feature flag for regional preferences APIs"
|
||||||
bug: "370379000"
|
bug: "370379000"
|
||||||
}
|
}
|
||||||
|
|
||||||
flag {
|
|
||||||
name: "settings_expressive_design_enabled"
|
|
||||||
namespace: "globalintl"
|
|
||||||
description: "Feature flag for expressive design"
|
|
||||||
bug: "385659296"
|
|
||||||
}
|
|
@@ -54,7 +54,6 @@ import com.android.internal.app.LocalePicker;
|
|||||||
import com.android.internal.app.LocaleStore;
|
import com.android.internal.app.LocaleStore;
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
import com.android.settings.RestrictedSettingsFragment;
|
import com.android.settings.RestrictedSettingsFragment;
|
||||||
import com.android.settings.flags.Flags;
|
|
||||||
import com.android.settings.overlay.FeatureFactory;
|
import com.android.settings.overlay.FeatureFactory;
|
||||||
import com.android.settings.search.BaseSearchIndexProvider;
|
import com.android.settings.search.BaseSearchIndexProvider;
|
||||||
import com.android.settingslib.search.SearchIndexable;
|
import com.android.settingslib.search.SearchIndexable;
|
||||||
@@ -62,6 +61,7 @@ import com.android.settingslib.search.SearchIndexableRaw;
|
|||||||
import com.android.settingslib.utils.CustomDialogHelper;
|
import com.android.settingslib.utils.CustomDialogHelper;
|
||||||
import com.android.settingslib.utils.StringUtil;
|
import com.android.settingslib.utils.StringUtil;
|
||||||
import com.android.settingslib.widget.LayoutPreference;
|
import com.android.settingslib.widget.LayoutPreference;
|
||||||
|
import com.android.settingslib.widget.SettingsThemeHelper;
|
||||||
|
|
||||||
import java.util.ArrayList;
|
import java.util.ArrayList;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
@@ -286,7 +286,7 @@ public class LocaleListEditor extends RestrictedSettingsFragment implements View
|
|||||||
private void setRemoveMode(boolean mRemoveMode) {
|
private void setRemoveMode(boolean mRemoveMode) {
|
||||||
this.mRemoveMode = mRemoveMode;
|
this.mRemoveMode = mRemoveMode;
|
||||||
mAdapter.setRemoveMode(mRemoveMode);
|
mAdapter.setRemoveMode(mRemoveMode);
|
||||||
if (Flags.settingsExpressiveDesignEnabled()) {
|
if (SettingsThemeHelper.isExpressiveTheme(getContext())) {
|
||||||
mAddLanguagePreference.setVisible(!mRemoveMode);
|
mAddLanguagePreference.setVisible(!mRemoveMode);
|
||||||
} else {
|
} else {
|
||||||
mAddLanguage.setVisibility(mRemoveMode ? View.INVISIBLE : View.VISIBLE);
|
mAddLanguage.setVisibility(mRemoveMode ? View.INVISIBLE : View.VISIBLE);
|
||||||
@@ -497,7 +497,7 @@ public class LocaleListEditor extends RestrictedSettingsFragment implements View
|
|||||||
list.setAdapter(mAdapter);
|
list.setAdapter(mAdapter);
|
||||||
list.setOnTouchListener(this);
|
list.setOnTouchListener(this);
|
||||||
list.requestFocus();
|
list.requestFocus();
|
||||||
if (Flags.settingsExpressiveDesignEnabled()) {
|
if (SettingsThemeHelper.isExpressiveTheme(getContext())) {
|
||||||
mAddLanguagePreference = getPreferenceScreen().findPreference(KEY_ADD_A_LANGUAGE);
|
mAddLanguagePreference = getPreferenceScreen().findPreference(KEY_ADD_A_LANGUAGE);
|
||||||
} else {
|
} else {
|
||||||
mAddLanguage = layout.findViewById(R.id.add_language);
|
mAddLanguage = layout.findViewById(R.id.add_language);
|
||||||
|
@@ -33,7 +33,6 @@ import com.android.settings.R
|
|||||||
import com.android.settings.applications.AppLocaleUtil
|
import com.android.settings.applications.AppLocaleUtil
|
||||||
import com.android.settings.applications.appinfo.AppLocaleDetails
|
import com.android.settings.applications.appinfo.AppLocaleDetails
|
||||||
import com.android.settings.core.SubSettingLauncher
|
import com.android.settings.core.SubSettingLauncher
|
||||||
import com.android.settings.flags.Flags
|
|
||||||
import com.android.settings.localepicker.AppLocalePickerActivity
|
import com.android.settings.localepicker.AppLocalePickerActivity
|
||||||
import com.android.settings.localepicker.AppLocalePickerFragment
|
import com.android.settings.localepicker.AppLocalePickerFragment
|
||||||
import com.android.settingslib.spa.framework.util.filterItem
|
import com.android.settingslib.spa.framework.util.filterItem
|
||||||
@@ -43,6 +42,7 @@ import com.android.settingslib.spaprivileged.model.app.AppRecord
|
|||||||
import com.android.settingslib.spaprivileged.model.app.userHandle
|
import com.android.settingslib.spaprivileged.model.app.userHandle
|
||||||
import com.android.settingslib.spaprivileged.template.app.AppListItem
|
import com.android.settingslib.spaprivileged.template.app.AppListItem
|
||||||
import com.android.settingslib.spaprivileged.template.app.AppListItemModel
|
import com.android.settingslib.spaprivileged.template.app.AppListItemModel
|
||||||
|
import com.android.settingslib.widget.SettingsThemeHelper
|
||||||
import kotlinx.coroutines.Dispatchers
|
import kotlinx.coroutines.Dispatchers
|
||||||
import kotlinx.coroutines.flow.Flow
|
import kotlinx.coroutines.flow.Flow
|
||||||
import kotlinx.coroutines.flow.combine
|
import kotlinx.coroutines.flow.combine
|
||||||
@@ -99,7 +99,7 @@ class AppLanguagesListModel(private val context: Context) : AppListModel<AppLang
|
|||||||
@Composable
|
@Composable
|
||||||
override fun AppListItemModel<AppLanguagesRecord>.AppItem() {
|
override fun AppListItemModel<AppLanguagesRecord>.AppItem() {
|
||||||
AppListItem {
|
AppListItem {
|
||||||
if (Flags.settingsExpressiveDesignEnabled()) {
|
if (SettingsThemeHelper.isExpressiveTheme(context)) {
|
||||||
val extra = Bundle()
|
val extra = Bundle()
|
||||||
extra.putString(AppLocalePickerFragment.ARG_PACKAGE_NAME, record.app.packageName)
|
extra.putString(AppLocalePickerFragment.ARG_PACKAGE_NAME, record.app.packageName)
|
||||||
extra.putInt(AppLocalePickerFragment.ARG_PACKAGE_UID, context.userId)
|
extra.putInt(AppLocalePickerFragment.ARG_PACKAGE_UID, context.userId)
|
||||||
|
Reference in New Issue
Block a user